Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2910023002: Ensure RemoteViewportIntersection rect persists across frame navigations (Closed)
Patch Set: dcheng comments addressed Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrameView.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
index c30f0442862025bbce8c46bf6b49d547409832da..98063fcc63a0f92eb7eb372293a1b4440d15af37 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
@@ -766,8 +766,8 @@ void WebFrameWidgetImpl::SetRemoteViewportIntersection(
// Remote viewports are only applicable to local frames with remote ancestors.
DCHECK(local_root_->Parent() && local_root_->Parent()->IsWebRemoteFrame());
- if (local_root_->GetFrameView()) {
- local_root_->GetFrameView()->SetViewportIntersectionFromParent(
+ if (local_root_->GetFrame()) {
dcheng 2017/05/30 22:14:26 Hmm... I wonder if we can get this when there's no
kenrb 2017/05/31 01:37:29 I'll take a look.
+ local_root_->GetFrame()->SetViewportIntersectionFromParent(
viewport_intersection);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrameView.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698