Ensure RemoteViewportIntersection rect persists across frame navigations

third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 748 matching lines @@
 
   bounds.Swap(result);
   return true;
 }
 
 void WebFrameWidgetImpl::SetRemoteViewportIntersection(
     const WebRect& viewport_intersection) {
   // Remote viewports are only applicable to local frames with remote ancestors.
   DCHECK(local_root_->Parent() && local_root_->Parent()->IsWebRemoteFrame());
 
-  if (local_root_->GetFrameView()) {
-    local_root_->GetFrameView()->SetViewportIntersectionFromParent(
+  if (local_root_->GetFrame()) {

[dcheng, 2017/05/30 22:14:26]

Hmm... I wonder if we can get this when there's no attached frame. Do you mind
poking at this in a followup and trying to DCHECK() these instead?

[kenrb, 2017/05/31 01:37:29]

I'll take a look.

+    local_root_->GetFrame()->SetViewportIntersectionFromParent(
         viewport_intersection);
   }
 }
 
 void WebFrameWidgetImpl::HandleMouseLeave(LocalFrame& main_frame,
                                           const WebMouseEvent& event) {
   // FIXME: WebWidget doesn't have the method below.
   // m_client->setMouseOverURL(WebURL());
   PageWidgetEventHandler::HandleMouseLeave(main_frame, event);
 }
@@ skipping 414 matching lines @@
              : nullptr;
 }
 
 LocalFrame* WebFrameWidgetImpl::FocusedLocalFrameAvailableForIme() const {
   if (!ime_accept_events_)
     return nullptr;
   return FocusedLocalFrameInWidget();
 }
 
 }  // namespace blink