Stability instrumentation: metrics for collection on crash

components/browser_watcher/stability_paths.h

Index: components/browser_watcher/stability_paths.h
diff --git a/components/browser_watcher/stability_paths.h b/components/browser_watcher/stability_paths.h
index 07216f1f75cb4a241b2b06d67bf8ccd9fc7cab00..53f2daa1133c1a712491ef4ef9640d73b5415aa8 100644
--- a/components/browser_watcher/stability_paths.h
+++ b/components/browser_watcher/stability_paths.h
@@ -35,8 +35,12 @@ bool GetStabilityFileForProcess(const base::Process& process,
 // Returns a pattern that matches file names returned by GetFileForProcess.
 base::FilePath::StringType GetStabilityFilePattern();
 
-// Marks the stability file for deletion.
-void MarkStabilityFileForDeletion(const base::FilePath& user_data_dir);
+// Marks the current process's stability file for deletion.
+void MarkOwnStabilityFileDeleted(const base::FilePath& user_data_dir);
+
+// Marks a stability file for deletion. Returns true if the persistent
+// allocator's state was set to deleted, false otherwise.
+bool MarkStabilityFileDeleted(const base::FilePath& file_path);

[bcwhite, 2017/05/31 15:41:19]

Under what conditions would it fail?

[manzagop (departed), 2017/05/31 19:57:23]

No longer can! I've renamed the function and moved the error logging inside. The
failure is if we can't get an allocator on the file and set the pma state.

 
 #endif  // defined(OS_WIN)