Stability instrumentation: metrics for collection on crash

components/browser_watcher/stability_paths.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_BROWSER_WATCHER_STABILITY_PATHS_H_
 #define COMPONENTS_BROWSER_WATCHER_STABILITY_PATHS_H_
 
 #include "base/files/file_path.h"
 #include "base/process/process.h"
 #include "build/build_config.h"
@@ skipping 17 matching lines @@
 
 // On success, returns true and |path| contains the path to the stability file.
 // On failure, returns false.
 bool GetStabilityFileForProcess(const base::Process& process,
                                 const base::FilePath& user_data_dir,
                                 base::FilePath* path);
 
 // Returns a pattern that matches file names returned by GetFileForProcess.
 base::FilePath::StringType GetStabilityFilePattern();
 
-// Marks the stability file for deletion.
-void MarkStabilityFileForDeletion(const base::FilePath& user_data_dir);
+// Marks the current process's stability file for deletion.
+void MarkOwnStabilityFileDeleted(const base::FilePath& user_data_dir);
+
+// Marks a stability file for deletion. Returns true if the persistent
+// allocator's state was set to deleted, false otherwise.
+bool MarkStabilityFileDeleted(const base::FilePath& file_path);

[bcwhite, 2017/05/31 15:41:19]

Under what conditions would it fail?

[manzagop (departed), 2017/05/31 19:57:23]

No longer can! I've renamed the function and moved the error logging inside. The
failure is if we can't get an allocator on the file and set the pma state.

 
 #endif  // defined(OS_WIN)
 
 }  // namespace browser_watcher
 
 #endif  // COMPONENTS_BROWSER_WATCHER_STABILITY_PATHS_H_