Replace deprecated base::NonThreadSafe in ipc in favor of SequenceChecker.

Replace deprecated base::NonThreadSafe in ipc in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2909993003
Cr-Commit-Position: refs/heads/master@{#475944}
Committed: https://chromium.googlesource.com/chromium/src/+/21edbfa38a6aac6c2f3dd7b024414725ad2afdbb

[gab, 2017-05-30 02:56:19]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-05-30 02:56:22]

Hi, this is an automated change made by https://crbug.com/676387#c8 and sharded
across directories for OWNERS.

No human has looked at this specific output yet, see cl description for things
to watch for.

If it LGTY, please CQ.

If it didn't pass CQ dry-run it may be a simple patch failure or an IWYU failure
from having this being a partial CL... please review anyways and a human will
look at the failure (and ping for re-review if anything major is required..). It
is known to compile all targets on Windows at r474679...  manual tweaks will
likely be required to smoothen things off, bear with me!

Thanks!
Gab

[commit-bot: I haz the power, 2017-05-30 02:57:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 03:12:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 03:12:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gab, 2017-05-30 14:44:43]

On 2017/05/30 02:56:22, gab wrote:
> Hi, this is an automated change made by https://crbug.com/676387#c8 and
sharded
> across directories for OWNERS.
> 
> No human has looked at this specific output yet, see cl description for things
> to watch for.
> 
> If it LGTY, please CQ.
> 
> If it didn't pass CQ dry-run it may be a simple patch failure or an IWYU
failure
> from having this being a partial CL... please review anyways and a human will
> look at the failure (and ping for re-review if anything major is required..).
It
> is known to compile all targets on Windows at r474679...  manual tweaks will
> likely be required to smoothen things off, bear with me!
> 
> Thanks!
> Gab

Compile failure is IWYU error which becomes irrelevant after
https://codereview.chromium.org/2907133003/, please review regardless.

[jam, 2017-05-30 16:51:49]

regarding SEQUENCE_CHECKER, the style guide discourages generating code by
macros. Are you sure that if the class was a noop, always defining it would have
a cost in optimized release builds?

[gab, 2017-05-30 18:53:07]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 18:53:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-05-30 18:56:55]

On 2017/05/30 16:51:49, jam wrote:
> regarding SEQUENCE_CHECKER, the style guide discourages generating code by
> macros. Are you sure that if the class was a noop, always defining it would
have
> a cost in optimized release builds?

Yep this was discussed a few times on chromium-dev and it does have a cost in
optimized release builds:
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/99pKNd2kCcg/Nx2-m...

Another prior discussion on this topic:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TivgMWBuTKI/dis...

[commit-bot: I haz the power, 2017-05-30 20:46:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 20:46:10]

Dry run: This issue passed the CQ dry run.

[jam, 2017-05-30 23:37:29]

On 2017/05/30 18:56:55, gab wrote:
> On 2017/05/30 16:51:49, jam wrote:
> > regarding SEQUENCE_CHECKER, the style guide discourages generating code by
> > macros. Are you sure that if the class was a noop, always defining it would
> have
> > a cost in optimized release builds?
> 
> Yep this was discussed a few times on chromium-dev and it does have a cost in
> optimized release builds:
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/99pKNd2kCcg/Nx2-m...
> 
> Another prior discussion on this topic:
>
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TivgMWBuTKI/dis...

Thanks for the background, I hadn't seen that. lgtm

[gab, 2017-05-31 16:31:34]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-05-31 16:32:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 16:49:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496248294067420, "parent_rev":
"485298e034374f06e4f3399276fe7c51857f1d76", "commit_rev":
"21edbfa38a6aac6c2f3dd7b024414725ad2afdbb"}

[commit-bot: I haz the power, 2017-05-31 16:49:24]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in ipc in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=jam@chromium.org
==========

to

==========
Replace deprecated base::NonThreadSafe in ipc in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2909993003
Cr-Commit-Position: refs/heads/master@{#475944}
Committed:
https://chromium.googlesource.com/chromium/src/+/21edbfa38a6aac6c2f3dd7b02441...
==========

[commit-bot: I haz the power, 2017-05-31 16:49:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/21edbfa38a6aac6c2f3dd7b02441...