Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2909983003: [loader] Make recipe engine support examples/ module subdir (Closed)

Created:
3 years, 6 months ago by iannucci
Modified:
3 years, 6 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[loader] Make recipe engine support examples/ module subdir This makes the example recipes mirror the tests recipes. After this lands I'll make similar transformations to the other repos and remove support for the bare example.py. R=dnj@chromium.org, nodir@chromium.org, phajdan.jr@chromium.org BUG= Review-Url: https://codereview.chromium.org/2909983003 Committed: https://github.com/luci/recipes-py/commit/84a695b241eb61b3b6d1a0fa9d63ef572d26cdbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -5816 lines) Patch
M recipe_engine/loader.py View 3 chunks +32 lines, -16 lines 0 comments Download
M recipe_engine/recipe_api.py View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_engine/unittests/run_test.py View 1 chunk +6 lines, -6 lines 0 comments Download
D recipe_modules/context/example.py View 1 chunk +0 lines, -44 lines 0 comments Download
D recipe_modules/context/example.expected/basic.json View 1 chunk +0 lines, -86 lines 0 comments Download
A + recipe_modules/context/examples/full.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/context/examples/full.expected/basic.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D recipe_modules/generator_script/example.py View 1 chunk +0 lines, -96 lines 0 comments Download
D recipe_modules/generator_script/example.expected/always_run.json View 1 chunk +0 lines, -78 lines 0 comments Download
D recipe_modules/generator_script/example.expected/basic.json View 1 chunk +0 lines, -35 lines 0 comments Download
D recipe_modules/generator_script/example.expected/basic_python.json View 1 chunk +0 lines, -40 lines 0 comments Download
D recipe_modules/generator_script/example.expected/malformed_command.json View 1 chunk +0 lines, -32 lines 0 comments Download
D recipe_modules/generator_script/example.expected/nested.json View 1 chunk +0 lines, -127 lines 0 comments Download
D recipe_modules/generator_script/example.expected/presentation.json View 1 chunk +0 lines, -43 lines 0 comments Download
A + recipe_modules/generator_script/examples/full.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/generator_script/examples/full.expected/always_run.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/generator_script/examples/full.expected/basic.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/generator_script/examples/full.expected/basic_python.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/generator_script/examples/full.expected/malformed_command.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/generator_script/examples/full.expected/nested.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/generator_script/examples/full.expected/presentation.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D recipe_modules/json/example.py View 1 chunk +0 lines, -112 lines 0 comments Download
D recipe_modules/json/example.expected/basic.json View 1 chunk +0 lines, -150 lines 0 comments Download
D recipe_modules/json/example.resources/cool_script.py View 1 chunk +0 lines, -14 lines 0 comments Download
A + recipe_modules/json/examples/full.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/json/examples/full.expected/basic.json View 2 chunks +2 lines, -2 lines 0 comments Download
A + recipe_modules/json/examples/full.resources/cool_script.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M recipe_modules/path/api.py View 4 chunks +33 lines, -3 lines 0 comments Download
D recipe_modules/path/example.py View 1 chunk +0 lines, -114 lines 0 comments Download
D recipe_modules/path/example.expected/linux.json View 1 chunk +0 lines, -91 lines 0 comments Download
D recipe_modules/path/example.expected/linux_kitchen.json View 1 chunk +0 lines, -91 lines 0 comments Download
D recipe_modules/path/example.expected/linux_luci.json View 1 chunk +0 lines, -91 lines 0 comments Download
D recipe_modules/path/example.expected/linux_swarming.json View 1 chunk +0 lines, -91 lines 0 comments Download
D recipe_modules/path/example.expected/mac.json View 1 chunk +0 lines, -91 lines 0 comments Download
D recipe_modules/path/example.expected/mac_kitchen.json View 1 chunk +0 lines, -91 lines 0 comments Download
D recipe_modules/path/example.expected/mac_luci.json View 1 chunk +0 lines, -91 lines 0 comments Download
D recipe_modules/path/example.expected/mac_swarming.json View 1 chunk +0 lines, -91 lines 0 comments Download
D recipe_modules/path/example.expected/win.json View 1 chunk +0 lines, -91 lines 0 comments Download
D recipe_modules/path/example.expected/win_kitchen.json View 1 chunk +0 lines, -91 lines 0 comments Download
D recipe_modules/path/example.expected/win_luci.json View 1 chunk +0 lines, -91 lines 0 comments Download
D recipe_modules/path/example.expected/win_swarming.json View 1 chunk +0 lines, -91 lines 0 comments Download
A + recipe_modules/path/examples/full.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/path/examples/full.expected/linux.json View 1 chunk +4 lines, -4 lines 0 comments Download
A + recipe_modules/path/examples/full.expected/linux_kitchen.json View 1 chunk +4 lines, -4 lines 0 comments Download
A + recipe_modules/path/examples/full.expected/linux_luci.json View 1 chunk +4 lines, -4 lines 0 comments Download
A + recipe_modules/path/examples/full.expected/linux_swarming.json View 1 chunk +4 lines, -4 lines 0 comments Download
A + recipe_modules/path/examples/full.expected/mac.json View 1 chunk +4 lines, -4 lines 0 comments Download
A + recipe_modules/path/examples/full.expected/mac_kitchen.json View 1 chunk +4 lines, -4 lines 0 comments Download
A + recipe_modules/path/examples/full.expected/mac_luci.json View 1 chunk +4 lines, -4 lines 0 comments Download
A + recipe_modules/path/examples/full.expected/mac_swarming.json View 1 chunk +4 lines, -4 lines 0 comments Download
A + recipe_modules/path/examples/full.expected/win.json View 1 chunk +4 lines, -4 lines 0 comments Download
A + recipe_modules/path/examples/full.expected/win_kitchen.json View 1 chunk +4 lines, -4 lines 0 comments Download
A + recipe_modules/path/examples/full.expected/win_luci.json View 1 chunk +4 lines, -4 lines 0 comments Download
A + recipe_modules/path/examples/full.expected/win_swarming.json View 1 chunk +4 lines, -4 lines 0 comments Download
D recipe_modules/platform/example.py View 1 chunk +0 lines, -22 lines 0 comments Download
D recipe_modules/platform/example.expected/four_cores.json View 1 chunk +0 lines, -21 lines 0 comments Download
D recipe_modules/platform/example.expected/linux64.json View 1 chunk +0 lines, -21 lines 0 comments Download
D recipe_modules/platform/example.expected/mac64.json View 1 chunk +0 lines, -21 lines 0 comments Download
D recipe_modules/platform/example.expected/win32.json View 1 chunk +0 lines, -21 lines 0 comments Download
A + recipe_modules/platform/examples/full.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/platform/examples/full.expected/four_cores.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/platform/examples/full.expected/linux64.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/platform/examples/full.expected/mac64.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/platform/examples/full.expected/win32.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D recipe_modules/properties/example.py View 1 chunk +0 lines, -72 lines 0 comments Download
D recipe_modules/properties/example.expected/basic.json View 1 chunk +0 lines, -45 lines 0 comments Download
D recipe_modules/properties/example.expected/buildbot_generic.json View 1 chunk +0 lines, -109 lines 0 comments Download
D recipe_modules/properties/example.expected/buildbot_git_scheduled.json View 1 chunk +0 lines, -141 lines 0 comments Download
D recipe_modules/properties/example.expected/buildbot_scheduled.json View 1 chunk +0 lines, -141 lines 0 comments Download
D recipe_modules/properties/example.expected/buildbot_tryserver.json View 1 chunk +0 lines, -181 lines 0 comments Download
D recipe_modules/properties/example.expected/buildbot_tryserver_gerrit.json View 1 chunk +0 lines, -173 lines 0 comments Download
D recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_both.json View 1 chunk +0 lines, -173 lines 0 comments Download
D recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_gerrit.json View 1 chunk +0 lines, -173 lines 0 comments Download
D recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_override_git.json View 1 chunk +0 lines, -173 lines 0 comments Download
D recipe_modules/properties/example.expected/dicts.json View 1 chunk +0 lines, -45 lines 0 comments Download
D recipe_modules/properties/example.expected/exception.json View 1 chunk +0 lines, -7 lines 0 comments Download
D recipe_modules/properties/example.expected/lists.json View 1 chunk +0 lines, -45 lines 0 comments Download
A + recipe_modules/properties/examples/full.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/properties/examples/full.expected/basic.json View 2 chunks +2 lines, -2 lines 0 comments Download
A + recipe_modules/properties/examples/full.expected/buildbot_generic.json View 2 chunks +2 lines, -2 lines 0 comments Download
A + recipe_modules/properties/examples/full.expected/buildbot_git_scheduled.json View 2 chunks +2 lines, -2 lines 0 comments Download
A + recipe_modules/properties/examples/full.expected/buildbot_scheduled.json View 2 chunks +2 lines, -2 lines 0 comments Download
A + recipe_modules/properties/examples/full.expected/buildbot_tryserver.json View 2 chunks +2 lines, -2 lines 0 comments Download
A + recipe_modules/properties/examples/full.expected/buildbot_tryserver_gerrit.json View 2 chunks +2 lines, -2 lines 0 comments Download
A + recipe_modules/properties/examples/full.expected/buildbot_tryserver_gerrit_override_both.json View 2 chunks +2 lines, -2 lines 0 comments Download
A + recipe_modules/properties/examples/full.expected/buildbot_tryserver_gerrit_override_gerrit.json View 2 chunks +2 lines, -2 lines 0 comments Download
A + recipe_modules/properties/examples/full.expected/buildbot_tryserver_gerrit_override_git.json View 2 chunks +2 lines, -2 lines 0 comments Download
A + recipe_modules/properties/examples/full.expected/dicts.json View 2 chunks +2 lines, -2 lines 0 comments Download
A + recipe_modules/properties/examples/full.expected/exception.json View 1 chunk +1 line, -1 line 0 comments Download
A + recipe_modules/properties/examples/full.expected/lists.json View 2 chunks +2 lines, -2 lines 0 comments Download
D recipe_modules/python/example.py View 1 chunk +0 lines, -48 lines 0 comments Download
D recipe_modules/python/example.expected/basic.json View 1 chunk +0 lines, -76 lines 0 comments Download
D recipe_modules/python/example.resources/test.py View 1 chunk +0 lines, -45 lines 0 comments Download
D recipe_modules/python/example.resources/test.vpython View 1 chunk +0 lines, -14 lines 0 comments Download
A + recipe_modules/python/examples/full.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/python/examples/full.expected/basic.json View 2 chunks +3 lines, -3 lines 0 comments Download
A + recipe_modules/python/examples/full.resources/test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/python/examples/full.resources/test.vpython View 0 chunks +-1 lines, --1 lines 0 comments Download
D recipe_modules/raw_io/example.py View 1 chunk +0 lines, -110 lines 0 comments Download
D recipe_modules/raw_io/example.expected/basic.json View 1 chunk +0 lines, -96 lines 0 comments Download
A + recipe_modules/raw_io/examples/full.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/raw_io/examples/full.expected/basic.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D recipe_modules/shutil/example.py View 1 chunk +0 lines, -77 lines 0 comments Download
D recipe_modules/shutil/example.expected/basic.json View 1 chunk +0 lines, -235 lines 0 comments Download
A + recipe_modules/shutil/examples/full.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/shutil/examples/full.expected/basic.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D recipe_modules/step/example.py View 1 chunk +0 lines, -189 lines 0 comments Download
D recipe_modules/step/example.expected/bad_return.json View 1 chunk +0 lines, -7 lines 0 comments Download
D recipe_modules/step/example.expected/basic.json View 1 chunk +0 lines, -147 lines 0 comments Download
D recipe_modules/step/example.expected/catch_timeout.json View 1 chunk +0 lines, -17 lines 0 comments Download
D recipe_modules/step/example.expected/defer_results.json View 1 chunk +0 lines, -129 lines 0 comments Download
D recipe_modules/step/example.expected/exceptional.json View 1 chunk +0 lines, -107 lines 0 comments Download
D recipe_modules/step/example.expected/infra_failure.json View 1 chunk +0 lines, -151 lines 0 comments Download
D recipe_modules/step/example.expected/invalid_access.json View 1 chunk +0 lines, -154 lines 0 comments Download
D recipe_modules/step/example.expected/timeout.json View 1 chunk +0 lines, -16 lines 0 comments Download
D recipe_modules/step/example.expected/warning.json View 1 chunk +0 lines, -115 lines 0 comments Download
A + recipe_modules/step/examples/full.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/step/examples/full.expected/bad_return.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/step/examples/full.expected/basic.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/step/examples/full.expected/catch_timeout.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/step/examples/full.expected/defer_results.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/step/examples/full.expected/exceptional.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/step/examples/full.expected/infra_failure.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/step/examples/full.expected/invalid_access.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/step/examples/full.expected/timeout.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/step/examples/full.expected/warning.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D recipe_modules/tempfile/example.py View 1 chunk +0 lines, -15 lines 0 comments Download
D recipe_modules/tempfile/example.expected/basic.json View 1 chunk +0 lines, -17 lines 0 comments Download
A + recipe_modules/tempfile/examples/full.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/tempfile/examples/full.expected/basic.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D recipe_modules/time/example.py View 1 chunk +0 lines, -21 lines 0 comments Download
D recipe_modules/time/example.expected/defaults.json View 1 chunk +0 lines, -14 lines 0 comments Download
D recipe_modules/time/example.expected/seed_and_step.json View 1 chunk +0 lines, -14 lines 0 comments Download
A + recipe_modules/time/examples/full.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/time/examples/full.expected/defaults.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/time/examples/full.expected/seed_and_step.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D recipe_modules/url/example.py View 1 chunk +0 lines, -108 lines 0 comments Download
D recipe_modules/url/example.expected/basic.json View 1 chunk +0 lines, -158 lines 0 comments Download
A + recipe_modules/url/examples/full.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/url/examples/full.expected/basic.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D recipe_modules/uuid/example.py View 1 chunk +0 lines, -17 lines 0 comments Download
D recipe_modules/uuid/example.expected/basic.json View 1 chunk +0 lines, -14 lines 0 comments Download
A + recipe_modules/uuid/examples/full.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/uuid/examples/full.expected/basic.json View 0 chunks +-1 lines, --1 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
iannucci
3 years, 6 months ago (2017-05-30 19:41:39 UTC) #1
iannucci
PTAL
3 years, 6 months ago (2017-05-30 22:41:17 UTC) #10
Paweł Hajdan Jr.
LGTM
3 years, 6 months ago (2017-05-31 15:26:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909983003/1
3 years, 6 months ago (2017-05-31 16:44:43 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 16:48:10 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/84a695b241eb61b3b6d1a0fa9d63ef572d2...

Powered by Google App Engine
This is Rietveld 408576698