Refactor variations_combinations.py to use testing configs

Refactor variations_combinations.py to use testing configs

Currently this won't work on Android because of a ChromeDriver bug. Need
to submit this first so that the bug is reproducable.

BUG=714827
Review-Url: https://codereview.chromium.org/2909943005
Cr-Commit-Position: refs/heads/master@{#475700}
Committed: https://chromium.googlesource.com/chromium/src/+/f8269fd7b3dda708afe0c78fc900568916bfa891

[Robert Ogden, 2017-05-30 21:44:57]

robertogden@chromium.org changed reviewers:
+ tbansal@chromium.org

[Robert Ogden, 2017-05-30 21:44:58]

Tarun, please take a look. Thanks!

[tbansal1, 2017-05-30 23:31:24]

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/common.py (right):

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:772: return testRunner.run(tests)
why was this changed?

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/variations_combinations.py (right):

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/variations_combinations.py:5: import io
May be add:
import fieldtrial_util

Similar to
https://cs.chromium.org/chromium/src/tools/perf/core/perf_benchmark.py?type=c...

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/variations_combinations.py:46: my_platform = 'mac'
add chromeos?

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/variations_combinations.py:47: return
fieldtrial_util.GenerateArgs(config_path, my_platform)
return an error if the platform is not supported>

[Robert Ogden, 2017-05-30 23:44:35]

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/common.py (right):

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:772: return testRunner.run(tests)
On 2017/05/30 23:31:23, tbansal1 wrote:
> why was this changed?

So that the variations framework can tell if a test passed

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/variations_combinations.py (right):

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/variations_combinations.py:5: import io
On 2017/05/30 23:31:23, tbansal1 wrote:
> May be add:
> import fieldtrial_util
> 
> Similar to
>
https://cs.chromium.org/chromium/src/tools/perf/core/perf_benchmark.py?type=c...
> 
> 

This is done below, after the sys.path.append. Should I move both lines up?

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/variations_combinations.py:46: my_platform = 'mac'
On 2017/05/30 23:31:23, tbansal1 wrote:
> add chromeos?

our integration test framework doesn't support ChromeOS yet

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/variations_combinations.py:47: return
fieldtrial_util.GenerateArgs(config_path, my_platform)
On 2017/05/30 23:31:23, tbansal1 wrote:
> return an error if the platform is not supported>

Done.

[tbansal1, 2017-05-30 23:50:12]

lgtm

Thanks for adding this framework.

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/variations_combinations.py (right):

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/variations_combinations.py:5: import io
On 2017/05/30 23:44:35, Robert Ogden wrote:
> On 2017/05/30 23:31:23, tbansal1 wrote:
> > May be add:
> > import fieldtrial_util
> > 
> > Similar to
> >
>
https://cs.chromium.org/chromium/src/tools/perf/core/perf_benchmark.py?type=c...
> > 
> > 
> 
> This is done below, after the sys.path.append. Should I move both lines up?

Aah, ok. This l-g-t-m.

https://codereview.chromium.org/2909943005/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/variations_combinations.py:46: my_platform = 'mac'
On 2017/05/30 23:44:35, Robert Ogden wrote:
> On 2017/05/30 23:31:23, tbansal1 wrote:
> > add chromeos?
> 
> our integration test framework doesn't support ChromeOS yet

Acknowledged.

[Robert Ogden, 2017-05-30 23:56:59]

The CQ bit was checked by robertogden@chromium.org

[commit-bot: I haz the power, 2017-05-30 23:57:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 00:08:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496188619762870,
"parent_rev": "c91b24c8f2f55e6a71a02c999fa69cfdf0745c3e", "commit_rev":
"f8269fd7b3dda708afe0c78fc900568916bfa891"}

[commit-bot: I haz the power, 2017-05-31 00:08:36]

Description was changed from

==========
Refactor variations_combinations.py to use testing configs

Currently this won't work on Android because of a ChromeDriver bug. Need
to submit this first so that the bug is reproducable.

BUG=714827
==========

to

==========
Refactor variations_combinations.py to use testing configs

Currently this won't work on Android because of a ChromeDriver bug. Need
to submit this first so that the bug is reproducable.

BUG=714827

Review-Url: https://codereview.chromium.org/2909943005
Cr-Commit-Position: refs/heads/master@{#475700}
Committed:
https://chromium.googlesource.com/chromium/src/+/f8269fd7b3dda708afe0c78fc900...
==========

[commit-bot: I haz the power, 2017-05-31 00:08:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f8269fd7b3dda708afe0c78fc900...