Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc

Issue 2909943003: Removing useless Win7 checks + standardize its use (Closed)
Patch Set: Fix reversed conditionnal Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
diff --git a/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc b/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
index ef906ffc62348b4f6d229a6b526b8290dccf662c..79aa8d6f01853d0f6730d8bdddad43e027268a55 100644
--- a/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
+++ b/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
@@ -17,7 +17,6 @@
#include "base/strings/utf_string_conversions.h"
#include "base/win/scoped_comptr.h"
#include "base/win/scoped_propvariant.h"
-#include "base/win/windows_version.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/profiles/profile.h"
@@ -183,10 +182,6 @@ class BrowserTestWithProfileShortcutManager : public InProcessBrowserTest {
// http://crbug.com/396344
IN_PROC_BROWSER_TEST_F(BrowserTestWithProfileShortcutManager,
DISABLED_WindowProperties) {
- // This test checks HWND properties that are only available on Win7+.
- if (base::win::GetVersion() < base::win::VERSION_WIN7)
- return;
-
// Single profile case. The profile name should not be shown.
WaitAndValidateBrowserWindowProperties(base::Bind(
&ValidateBrowserWindowProperties, browser(), base::string16()));
@@ -230,10 +225,6 @@ IN_PROC_BROWSER_TEST_F(BrowserTestWithProfileShortcutManager,
// http://crbug.com/396344
IN_PROC_BROWSER_TEST_F(BrowserWindowPropertyManagerTest, DISABLED_HostedApp) {
- // This test checks HWND properties that are only available on Win7+.
- if (base::win::GetVersion() < base::win::VERSION_WIN7)
- return;
-
// Load an app.
const extensions::Extension* extension =
LoadExtension(test_data_dir_.AppendASCII("app/"));

Powered by Google App Engine
This is Rietveld 408576698