chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc - Issue 2909943003: Removing useless Win7 checks + standardize its use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc

Issue 2909943003: Removing useless Win7 checks + standardize its use (Closed)

Patch Set: Fix reversed conditionnal Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/pdf/adobe_reader_info_win.cc ('K') | « chrome/browser/ui/startup/startup_browser_creator_impl.cc ('k') | chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc » ('j') | chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc

diff --git a/chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc b/chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc

index bbd6e944a22e48920d9394240488cfb59e3b12ca..f70dabe1dbda7b7f9a9ce4536176e36f8de3e225 100644

--- a/chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc

+++ b/chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc

@@ -325,7 +325,7 @@ MARGINS BrowserDesktopWindowTreeHostWin::GetDWMFrameMargins() const {

gfx::Point right_bottom = display::win::ScreenWin::DIPToClientPoint(

hwnd, gfx::Point(thicknesses.right(), thicknesses.bottom()));

- if (base::win::GetVersion() <= base::win::VERSION_WIN7) {

+ if (base::win::GetVersion() < base::win::VERSION_WIN8) {

// The 2 px (not DIP) at the inner edges of the glass are a light and

// dark line, so we must inset further to account for those.

constexpr gfx::Vector2d kDWMEdgeThickness(2, 2);