Expand TextCheckingParagraph::OffsetTo() into SelectionController::MarkAndReplaceFor()

Expand TextCheckingParagraph::OffsetTo() into SelectionController::MarkAndReplaceFor()

This patch expands |TextCheckingParagraph::OffsetTo()| into
|SelectionController::MarkAndReplaceFor()| with optimizations, see below,
because it is called once for improving code health.

Since |TextCheckingParagraph| object |paragraph| holds single range
|checking_range|, we can hold
|TextCheckingParagraph::OffsetAsRange().StartPosition()| to
|checking_range.StartPosition()|.

When |caret_position < paragraph_start|, we don't need to consider it, because of
caret is placed before checked range.

This patch is a preparation of patch[1].

[1] http://crrev.com/2912053002: Call TextIterator constructor with proper range

BUG=727537
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2909923005
Cr-Commit-Position: refs/heads/master@{#475718}
Committed: https://chromium.googlesource.com/chromium/src/+/9a241f0157e83c8defd3ee25b06232f6688bf86b

[yosin_UTC9, 2017-05-30 09:34:51]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 09:35:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-05-30 09:41:11]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 09:41:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-05-30 09:41:46]

Patchset #1 (id:1) has been deleted

[yosin_UTC9, 2017-05-30 09:48:11]

Description was changed from

==========
2017-05-30T18:33:35

BUG=727537

2017-05-30T18:33:31
==========

to

==========
Make SpellChecker to call RangeLength() with proper range

This patch changes |SelectionController::MarkAndReplaceFor()| to call
|RangeLength()|, which constructs |TextIterator|,  with proper range,
start <= end, as preparation of making |TextIterator| constructor to take only
proper range[1].

This patch expands |TextCheckingParagraph::OffsetTo()| to hoist |RangeLength()|
call into |MarkAndReplaceFor()| because |OffsetTo()| is called once only and
|paragraph| is a simple case of |TextCheckingParagraph|, checking range and
paragraph range are same.

Following patch will get rid of |TextCheckingParagraph::OffsetTo()|.

[1] http://crrev.com/2912053002: Call TextIterator constructor with proper range

BUG=727537
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-05-30 09:52:47]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 09:52:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-05-30 10:01:52]

Description was changed from

==========
Make SpellChecker to call RangeLength() with proper range

This patch changes |SelectionController::MarkAndReplaceFor()| to call
|RangeLength()|, which constructs |TextIterator|,  with proper range,
start <= end, as preparation of making |TextIterator| constructor to take only
proper range[1].

This patch expands |TextCheckingParagraph::OffsetTo()| to hoist |RangeLength()|
call into |MarkAndReplaceFor()| because |OffsetTo()| is called once only and
|paragraph| is a simple case of |TextCheckingParagraph|, checking range and
paragraph range are same.

Following patch will get rid of |TextCheckingParagraph::OffsetTo()|.

[1] http://crrev.com/2912053002: Call TextIterator constructor with proper range

BUG=727537
TEST=n/a; no behavior changes
==========

to

==========
Expand TextCheckingParagraph::OffsetTo() into
SelectionController::MarkAndReplaceFor()

This patch expands |TextCheckingParagraph::OffsetTo()| into
|SelectionController::MarkAndReplaceFor()| with optimizations, see below,
because it is called once for improving code health.

Since |TextCheckingParagraph| object |paragraph| holds single range
|checking_range|, we can hold
|TextCheckingParagraph::OffsetAsRange().StartPosition()| to
|checking_range.StartPosition()|.

When |caret_position < paragraph_start|, we don't need to consider it.

[1] http://crrev.com/2912053002: Call TextIterator constructor with proper range

BUG=727537
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-05-30 10:03:34]

Description was changed from

==========
Expand TextCheckingParagraph::OffsetTo() into
SelectionController::MarkAndReplaceFor()

This patch expands |TextCheckingParagraph::OffsetTo()| into
|SelectionController::MarkAndReplaceFor()| with optimizations, see below,
because it is called once for improving code health.

Since |TextCheckingParagraph| object |paragraph| holds single range
|checking_range|, we can hold
|TextCheckingParagraph::OffsetAsRange().StartPosition()| to
|checking_range.StartPosition()|.

When |caret_position < paragraph_start|, we don't need to consider it.

[1] http://crrev.com/2912053002: Call TextIterator constructor with proper range

BUG=727537
TEST=n/a; no behavior changes
==========

to

==========
Expand TextCheckingParagraph::OffsetTo() into
SelectionController::MarkAndReplaceFor()

This patch expands |TextCheckingParagraph::OffsetTo()| into
|SelectionController::MarkAndReplaceFor()| with optimizations, see below,
because it is called once for improving code health.

Since |TextCheckingParagraph| object |paragraph| holds single range
|checking_range|, we can hold
|TextCheckingParagraph::OffsetAsRange().StartPosition()| to
|checking_range.StartPosition()|.

When |caret_position < paragraph_start|, we don't need to consider it, because
of
caret is placed before checked range.

[1] http://crrev.com/2912053002: Call TextIterator constructor with proper range

BUG=727537
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-05-30 10:03:44]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 10:04:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-05-30 10:05:25]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-05-30 10:05:26]

PTAL

Note: patch[1] is succeeded.

[yosin_UTC9, 2017-05-30 10:06:19]

Description was changed from

==========
Expand TextCheckingParagraph::OffsetTo() into
SelectionController::MarkAndReplaceFor()

This patch expands |TextCheckingParagraph::OffsetTo()| into
|SelectionController::MarkAndReplaceFor()| with optimizations, see below,
because it is called once for improving code health.

Since |TextCheckingParagraph| object |paragraph| holds single range
|checking_range|, we can hold
|TextCheckingParagraph::OffsetAsRange().StartPosition()| to
|checking_range.StartPosition()|.

When |caret_position < paragraph_start|, we don't need to consider it, because
of
caret is placed before checked range.

[1] http://crrev.com/2912053002: Call TextIterator constructor with proper range

BUG=727537
TEST=n/a; no behavior changes
==========

to

==========
Expand TextCheckingParagraph::OffsetTo() into
SelectionController::MarkAndReplaceFor()

This patch expands |TextCheckingParagraph::OffsetTo()| into
|SelectionController::MarkAndReplaceFor()| with optimizations, see below,
because it is called once for improving code health.

Since |TextCheckingParagraph| object |paragraph| holds single range
|checking_range|, we can hold
|TextCheckingParagraph::OffsetAsRange().StartPosition()| to
|checking_range.StartPosition()|.

When |caret_position < paragraph_start|, we don't need to consider it, because
of
caret is placed before checked range.

This patch is a preparation of patch[1].

[1] http://crrev.com/2912053002: Call TextIterator constructor with proper range

BUG=727537
TEST=n/a; no behavior changes
==========

[commit-bot: I haz the power, 2017-05-30 12:35:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 12:35:03]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-05-30 21:15:24]

lgtm

[yosin_UTC9, 2017-05-31 01:05:40]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-05-31 01:06:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 01:16:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496192740454760,
"parent_rev": "0711a0a702c23b484eadb514070f20f58b97bb35", "commit_rev":
"9a241f0157e83c8defd3ee25b06232f6688bf86b"}

[commit-bot: I haz the power, 2017-05-31 01:16:12]

Description was changed from

==========
Expand TextCheckingParagraph::OffsetTo() into
SelectionController::MarkAndReplaceFor()

This patch expands |TextCheckingParagraph::OffsetTo()| into
|SelectionController::MarkAndReplaceFor()| with optimizations, see below,
because it is called once for improving code health.

Since |TextCheckingParagraph| object |paragraph| holds single range
|checking_range|, we can hold
|TextCheckingParagraph::OffsetAsRange().StartPosition()| to
|checking_range.StartPosition()|.

When |caret_position < paragraph_start|, we don't need to consider it, because
of
caret is placed before checked range.

This patch is a preparation of patch[1].

[1] http://crrev.com/2912053002: Call TextIterator constructor with proper range

BUG=727537
TEST=n/a; no behavior changes
==========

to

==========
Expand TextCheckingParagraph::OffsetTo() into
SelectionController::MarkAndReplaceFor()

This patch expands |TextCheckingParagraph::OffsetTo()| into
|SelectionController::MarkAndReplaceFor()| with optimizations, see below,
because it is called once for improving code health.

Since |TextCheckingParagraph| object |paragraph| holds single range
|checking_range|, we can hold
|TextCheckingParagraph::OffsetAsRange().StartPosition()| to
|checking_range.StartPosition()|.

When |caret_position < paragraph_start|, we don't need to consider it, because
of
caret is placed before checked range.

This patch is a preparation of patch[1].

[1] http://crrev.com/2912053002: Call TextIterator constructor with proper range

BUG=727537
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2909923005
Cr-Commit-Position: refs/heads/master@{#475718}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a241f0157e83c8defd3ee25b062...
==========

[commit-bot: I haz the power, 2017-05-31 01:16:13]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9a241f0157e83c8defd3ee25b062...