Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 2909903002: Revert of Changing default Windows compiler to VS2017 (Closed)

Created:
3 years, 6 months ago by Nico
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Changing default Windows compiler to VS2017 (patchset #1 id:1 of https://codereview.chromium.org/2877993002/ ) Reason for revert: We have a canary. Original issue's description: > Changing default Windows compiler to VS2017 > > Doing another VS2017 test over the week end now that the PGO issues have > been fixed. > > This CL is currently purely for testing purposes and will be reverted by > the end of the week end. > > BUG=683729 > > Review-Url: https://codereview.chromium.org/2877993002 > Cr-Commit-Position: refs/heads/master@{#475212} > Committed: https://chromium.googlesource.com/chromium/src/+/833aa96095e1f827ffc05af8bf545a094ffa6e35 TBR=brucedawson@chromium.org,sebmarchand@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=683729 Review-Url: https://codereview.chromium.org/2909903002 Cr-Commit-Position: refs/heads/master@{#475354} Committed: https://chromium.googlesource.com/chromium/src/+/5ea5799ced8c179ee57cf877d370e763e76d819c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/vs_toolchain.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
Created Revert of Changing default Windows compiler to VS2017
3 years, 6 months ago (2017-05-29 13:45:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909903002/1
3 years, 6 months ago (2017-05-29 13:45:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5ea5799ced8c179ee57cf877d370e763e76d819c
3 years, 6 months ago (2017-05-29 15:14:42 UTC) #6
Sébastien Marchand
3 years, 6 months ago (2017-05-29 15:22:03 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698