Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2909693002: Ensure BottomSheet#getActiveTab returns non-null after load. (Closed)

Created:
3 years, 7 months ago by Ted C
Modified:
3 years, 7 months ago
Reviewers:
mdjones
CC:
chromium-reviews, agrieve+watch_chromium.org, Theresa
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure BottomSheet#getActiveTab returns non-null after load. BUG=725688 Review-Url: https://codereview.chromium.org/2909693002 Cr-Commit-Position: refs/heads/master@{#475154} Committed: https://chromium.googlesource.com/chromium/src/+/189dd02cbb3d5187ee70e67d51a09f6d274d3a6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ted C
mdjones - PTAL The problem is loadUrl is called and isShowingNewTabUi returns true until the ...
3 years, 7 months ago (2017-05-26 18:40:46 UTC) #2
mdjones
lgtm, we are starting to run into a lot of state based problems like this. ...
3 years, 7 months ago (2017-05-26 21:02:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909693002/1
3 years, 7 months ago (2017-05-26 21:17:26 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 22:03:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/189dd02cbb3d5187ee70e67d51a0...

Powered by Google App Engine
This is Rietveld 408576698