Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2909683002:
Track currently bound external and multisample textures. (Closed)
|
Created:
3 years, 7 months ago by Geoff Lang Modified:
3 years, 6 months ago Reviewers:
Zhenyao Mo CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionTrack currently bound external and multisample textures.
This caused assertions in glBindTexture even when binding 0. Caught by
the fuzzer which uses an ES 3.1 context.
BUG=726265
BUG=719933
BUG=719803
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2909683002
Cr-Commit-Position: refs/heads/master@{#475912}
Committed: https://chromium.googlesource.com/chromium/src/+/59d2ca1729430fc7713e642d04a772773248f030
Patch Set 1 #
Total comments: 2
Messages
Total messages: 16 (10 generated)
Description was changed from ========== Track currently bound external and multisample textures. This caused assertions in glBindTexture even when binding 0. Caught by the fuzzer which uses an ES 3.1 context. BUG=726265 BUG=719933 BUG=719803 ========== to ========== Track currently bound external and multisample textures. This caused assertions in glBindTexture even when binding 0. Caught by the fuzzer which uses an ES 3.1 context. BUG=726265 BUG=719933 BUG=719803 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Track currently bound external and multisample textures. This caused assertions in glBindTexture even when binding 0. Caught by the fuzzer which uses an ES 3.1 context. BUG=726265 BUG=719933 BUG=719803 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Track currently bound external and multisample textures. This caused assertions in glBindTexture even when binding 0. Caught by the fuzzer which uses an ES 3.1 context. BUG=726265 BUG=719933 BUG=719803 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
geofflang@chromium.org changed reviewers: + zmo@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2909683002/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc (right): https://codereview.chromium.org/2909683002/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc:213: if (feature_info_->gl_version_info().IsAtLeastGLES(3, 0)) { Are you saying we will only create ES3 ANGLE contexts if we ask for WebGL2 or ES3 decoder?
https://codereview.chromium.org/2909683002/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc (right): https://codereview.chromium.org/2909683002/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc:213: if (feature_info_->gl_version_info().IsAtLeastGLES(3, 0)) { On 2017/05/26 22:48:10, Zhenyao Mo wrote: > Are you saying we will only create ES3 ANGLE contexts if we ask for WebGL2 or > ES3 decoder? Correct, this is how ANGLE determines if it should do WebGL 1 or WebGL 2 validation as well.
On 2017/05/29 13:47:44, Geoff Lang wrote: > https://codereview.chromium.org/2909683002/diff/1/gpu/command_buffer/service/... > File gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc (right): > > https://codereview.chromium.org/2909683002/diff/1/gpu/command_buffer/service/... > gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc:213: if > (feature_info_->gl_version_info().IsAtLeastGLES(3, 0)) { > On 2017/05/26 22:48:10, Zhenyao Mo wrote: > > Are you saying we will only create ES3 ANGLE contexts if we ask for WebGL2 or > > ES3 decoder? > > Correct, this is how ANGLE determines if it should do WebGL 1 or WebGL 2 > validation as well. lgtm
The CQ bit was checked by geofflang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496239436959020, "parent_rev":
"72a4525096d5c8132af0c45246a06d369b01561c", "commit_rev":
"59d2ca1729430fc7713e642d04a772773248f030"}
Message was sent while issue was closed.
Description was changed from ========== Track currently bound external and multisample textures. This caused assertions in glBindTexture even when binding 0. Caught by the fuzzer which uses an ES 3.1 context. BUG=726265 BUG=719933 BUG=719803 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Track currently bound external and multisample textures. This caused assertions in glBindTexture even when binding 0. Caught by the fuzzer which uses an ES 3.1 context. BUG=726265 BUG=719933 BUG=719803 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2909683002 Cr-Commit-Position: refs/heads/master@{#475912} Committed: https://chromium.googlesource.com/chromium/src/+/59d2ca1729430fc7713e642d04a7... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/59d2ca1729430fc7713e642d04a7... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
