Change DumpProcessWithoutCrash to use load-time dynamic linking

components/crash/content/app/crashpad_win.cc

Index: components/crash/content/app/crashpad_win.cc
diff --git a/components/crash/content/app/crashpad_win.cc b/components/crash/content/app/crashpad_win.cc
index 77ccc323567b71aaef640ba1457e07036d14fd30..574e5392f03408089d6cf3ea6f8135f3904944fc 100644
--- a/components/crash/content/app/crashpad_win.cc
+++ b/components/crash/content/app/crashpad_win.cc
@@ -157,19 +157,12 @@ base::FilePath PlatformCrashpadInitialization(
   return database_path;
 }
 
-// TODO(scottmg): http://crbug.com/546288 These exported functions are for
-// compatibility with how Breakpad worked, but it seems like there's no need to
-// do the CreateRemoteThread() dance with a minor extension of the Crashpad API
-// (to just pass the pid we want a dump for). We should add that and then modify
-// hang_crash_dump_win.cc to work in a more direct manner.
-
-// Used for dumping a process state when there is no crash.
-extern "C" void __declspec(dllexport) __cdecl DumpProcessWithoutCrash() {
-  CRASHPAD_SIMULATE_CRASH();
-}
-
 namespace {
 
+void DumpProcessWithoutCrash() {
+    CRASHPAD_SIMULATE_CRASH();

[scottmg, 2017/06/15 23:08:47]

indent. ... In fact, we don't need this function any more right because we're
not GetProcAddress()ing it any more?

Can you just inline CRASHPAD_SIMULATE_CRASH() into the two functions below
instead?

[Will Harris, 2017/06/15 23:37:24]

CRASHPAD_SIMULATE_CRASH calls code linked with chrome_elf.dll so can't be called
outside chrome_elf module, unless I'm confused.

[scottmg, 2017/06/16 00:26:24]

I'm not sure what you mean. We're calling it right here?

I just mean this local namespace{} DumpProcessWithoutCrash() function isn't
necessary because it's only used in two locations,
DumpProcessForHungInputThread() and DumpProcessForHungInputNoCrashKeysThread()
below. So instead of having a separate function, it can just be put right there.

[Will Harris, 2017/06/21 14:31:26]

only one function exists now.

+}
+
 // We need to prevent ICF from folding DumpProcessForHungInputThread(),
 // DumpProcessForHungInputNoCrashKeysThread() together, since that makes them
 // indistinguishable in crash dumps. We do this by making the function