Change DumpProcessWithoutCrash to use load-time dynamic linking

components/crash/content/app/crashpad_win.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/crash/content/app/crashpad.h"
 
 #include <memory>
 
 #include "base/debug/crash_logging.h"
 #include "base/environment.h"
@@ skipping 139 matching lines @@
   } else {
     std::string pipe_name_utf8;
     if (env->GetVar(kPipeNameVar, &pipe_name_utf8)) {
       GetCrashpadClient().SetHandlerIPCPipe(base::UTF8ToUTF16(pipe_name_utf8));
     }
   }
 
   return database_path;
 }
 
-// TODO(scottmg): http://crbug.com/546288 These exported functions are for
-// compatibility with how Breakpad worked, but it seems like there's no need to
-// do the CreateRemoteThread() dance with a minor extension of the Crashpad API
-// (to just pass the pid we want a dump for). We should add that and then modify
-// hang_crash_dump_win.cc to work in a more direct manner.
-
-// Used for dumping a process state when there is no crash.
-extern "C" void __declspec(dllexport) __cdecl DumpProcessWithoutCrash() {
-  CRASHPAD_SIMULATE_CRASH();
-}
-
 namespace {
 
+void DumpProcessWithoutCrash() {
+    CRASHPAD_SIMULATE_CRASH();

[scottmg, 2017/06/15 23:08:47]

indent. ... In fact, we don't need this function any more right because we're
not GetProcAddress()ing it any more?

Can you just inline CRASHPAD_SIMULATE_CRASH() into the two functions below
instead?

[Will Harris, 2017/06/15 23:37:24]

CRASHPAD_SIMULATE_CRASH calls code linked with chrome_elf.dll so can't be called
outside chrome_elf module, unless I'm confused.

[scottmg, 2017/06/16 00:26:24]

I'm not sure what you mean. We're calling it right here?

I just mean this local namespace{} DumpProcessWithoutCrash() function isn't
necessary because it's only used in two locations,
DumpProcessForHungInputThread() and DumpProcessForHungInputNoCrashKeysThread()
below. So instead of having a separate function, it can just be put right there.

[Will Harris, 2017/06/21 14:31:26]

only one function exists now.

+}
+
 // We need to prevent ICF from folding DumpProcessForHungInputThread(),
 // DumpProcessForHungInputNoCrashKeysThread() together, since that makes them
 // indistinguishable in crash dumps. We do this by making the function
 // bodies unique, and prevent optimization from shuffling things around.
 MSVC_DISABLE_OPTIMIZE()
 MSVC_PUSH_DISABLE_WARNING(4748)
 
 // TODO(dtapuska): Remove when enough information is gathered where the crash
 // reports without crash keys come from.
 DWORD WINAPI DumpProcessForHungInputThread(void* crash_keys_str) {
@@ skipping 147 matching lines @@
 void __declspec(dllexport) __cdecl UnregisterNonABICompliantCodeRange(
     void* start) {
   ExceptionHandlerRecord* record =
       reinterpret_cast<ExceptionHandlerRecord*>(start);
 
   CHECK(RtlDeleteFunctionTable(&record->runtime_function));
 }
 #endif  // ARCH_CPU_X86_64
 
 }  // extern "C"