Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome_elf/chrome_elf_main.cc

Issue 2909623002: Change DumpProcessWithoutCrash to use load-time dynamic linking (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/app/chrome_main.cc ('K') | « chrome_elf/chrome_elf_main.h ('k') | chrome_elf/crash/crash_helper.h » ('j') | chrome_elf/crash/crash_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_elf/chrome_elf_main.cc
diff --git a/chrome_elf/chrome_elf_main.cc b/chrome_elf/chrome_elf_main.cc
index 9803382df5180c50b125d91044428ce6abb4c5dd..a3e04b2ffdb26dc3941d749237485978b6ebab4e 100644
--- a/chrome_elf/chrome_elf_main.cc
+++ b/chrome_elf/chrome_elf_main.cc
@@ -29,6 +29,10 @@ void SignalChromeElf() {
blacklist::ResetBeacon();
}
+void (*GetDumpWithoutCrashingFunction())() {
+ return elf_crash::GetDumpWithoutCrashingFunction();
scottmg 2017/06/15 23:08:47 And chrome_main is calling this one right?
Will Harris 2017/06/15 23:37:24 yes, in chrome_elf via dynamic linkage.
+}
+
BOOL APIENTRY DllMain(HMODULE module, DWORD reason, LPVOID reserved) {
if (reason == DLL_PROCESS_ATTACH) {
install_static::InitializeProductDetailsForPrimaryModule();
« chrome/app/chrome_main.cc ('K') | « chrome_elf/chrome_elf_main.h ('k') | chrome_elf/crash/crash_helper.h » ('j') | chrome_elf/crash/crash_helper.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698