Change DumpProcessWithoutCrash to use load-time dynamic linking

chrome_elf/chrome_elf_main.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_elf/chrome_elf_main.h"
 
 #include <assert.h>
 #include <windows.h>
 
 #include "chrome/install_static/install_details.h"
@@ skipping 11 matching lines @@
 #ifdef _DEBUG
     assert(false);
 #endif  // _DEBUG
   }
 }
 
 void SignalChromeElf() {
   blacklist::ResetBeacon();
 }
 
+void (*GetDumpWithoutCrashingFunction())() {
+  return elf_crash::GetDumpWithoutCrashingFunction();

[scottmg, 2017/06/15 23:08:47]

And chrome_main is calling this one right?

[Will Harris, 2017/06/15 23:37:24]

yes, in chrome_elf via dynamic linkage.

+}
+
 BOOL APIENTRY DllMain(HMODULE module, DWORD reason, LPVOID reserved) {
   if (reason == DLL_PROCESS_ATTACH) {
     install_static::InitializeProductDetailsForPrimaryModule();
 
     // CRT on initialization installs an exception filter which calls
     // TerminateProcess. We need to hook CRT's attempt to set an exception.
     elf_crash::DisableSetUnhandledExceptionFilter();
 
     __try {
       blacklist::Initialize(false);  // Don't force, abort if beacon is present.
     } __except (elf_crash::GenerateCrashDump(GetExceptionInformation())) {
     }
   } else if (reason == DLL_PROCESS_DETACH) {
     elf_crash::ShutdownCrashReporting();
   }
   return TRUE;
 }