Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2909593002: Disable tests on VS 2017 Preview, code-gen bug (Closed)

Created:
3 years, 7 months ago by brucedawson
Modified:
3 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable tests on VS 2017 Preview, code-gen bug VS 2017 has a code-gen bug, discussed and reported here: https://developercommunity.visualstudio.com/content/problem/40904/bad-code-gen-in-chromes-mojo-public-bindings-unitt.html As of VS 2017 Update 3 Preview 1 the bug is still not fixed, so this CL adjusts the checks to continue disabling the failing tests to allow testing with this VC version. The next preview should have the fix - probably. crrev.com/2826713003 disabled the tests for VS 2017 RTM. R=jam@chromium.org BUG=723893 Review-Url: https://codereview.chromium.org/2909593002 Cr-Commit-Position: refs/heads/master@{#475017} Committed: https://chromium.googlesource.com/chromium/src/+/6d1398efad86b7c862e83719602aed55c35d0e28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M mojo/public/cpp/bindings/tests/pickle_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
brucedawson
This is an update to a previous change to work-around a VS 2017 compiler bug. ...
3 years, 7 months ago (2017-05-26 03:15:36 UTC) #3
jam
lgtm
3 years, 7 months ago (2017-05-26 14:35:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909593002/1
3 years, 7 months ago (2017-05-26 15:55:39 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 16:01:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6d1398efad86b7c862e83719602a...

Powered by Google App Engine
This is Rietveld 408576698