Use the name of the default search engine in the search geo disclosure.

Use the name of the default search engine in the search geo disclosure.

The disclosure can now be shown for and HTTPS search engine that has
been set to the default, and which uses the geolocation API.

BUG=700250
Review-Url: https://codereview.chromium.org/2909583002
Cr-Commit-Position: refs/heads/master@{#474941}
Committed: https://chromium.googlesource.com/chromium/src/+/9f63aac7dcb8a3d51eb3743bf352b06e75153f11

[benwells, 2017-05-26 01:13:37]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[benwells, 2017-05-26 01:14:57]

benwells@chromium.org changed reviewers:
+ timloh@chromium.org

[commit-bot: I haz the power, 2017-05-26 01:15:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 03:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 03:37:24]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Timothy Loh, 2017-05-26 03:58:07]

lgtm

https://codereview.chromium.org/2909583002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2909583002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:12274: <ph
name="SEARCH_ENGINE_NAME">$1<ex>Name of the default search engine</ex></ph> uses
your location to give you local content. You can change this in <ph
name="SETTINGS_LINK">$2<ex>Link to Settings page</ex></ph>.
I think <ex> is supposed to contain an example, e.g. Google, not a description.

[benwells, 2017-05-26 04:52:02]

https://codereview.chromium.org/2909583002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2909583002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:12274: <ph
name="SEARCH_ENGINE_NAME">$1<ex>Name of the default search engine</ex></ph> uses
your location to give you local content. You can change this in <ph
name="SETTINGS_LINK">$2<ex>Link to Settings page</ex></ph>.
On 2017/05/26 03:58:06, Timothy Loh wrote:
> I think <ex> is supposed to contain an example, e.g. Google, not a
description.

Done.

[benwells, 2017-05-26 04:52:05]

The CQ bit was checked by benwells@chromium.org

[benwells, 2017-05-26 04:52:06]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2909583002/#ps20001
(title: "Feedback")

[commit-bot: I haz the power, 2017-05-26 04:52:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 06:27:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495774325793670,
"parent_rev": "0827cd5289824410906172f4852f5f7e308d505c", "commit_rev":
"9f63aac7dcb8a3d51eb3743bf352b06e75153f11"}

[commit-bot: I haz the power, 2017-05-26 06:27:52]

Description was changed from

==========
Use the name of the default search engine in the search geo disclosure.

The disclosure can now be shown for and HTTPS search engine that has
been set to the default, and which uses the geolocation API.

BUG=700250
==========

to

==========
Use the name of the default search engine in the search geo disclosure.

The disclosure can now be shown for and HTTPS search engine that has
been set to the default, and which uses the geolocation API.

BUG=700250

Review-Url: https://codereview.chromium.org/2909583002
Cr-Commit-Position: refs/heads/master@{#474941}
Committed:
https://chromium.googlesource.com/chromium/src/+/9f63aac7dcb8a3d51eb3743bf352...
==========

[commit-bot: I haz the power, 2017-05-26 06:27:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9f63aac7dcb8a3d51eb3743bf352...