Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2909523003: [Extensions Bindings] Update declarativeContent CSS validation test (Closed)

Created:
3 years, 7 months ago by Devlin
Modified:
3 years, 7 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, jam, darin-cc_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, jbroman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Update declarativeContent CSS validation test Update the declarativeContent CSS validation test to accept errors from either the JS bindings system or the native bindings system. BUG=653596 Review-Url: https://codereview.chromium.org/2909523003 Cr-Commit-Position: refs/heads/master@{#474817} Committed: https://chromium.googlesource.com/chromium/src/+/3137d1a8be97dbc4fe14075d61458ce9a5e6219e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Devlin
lazyboy@, mind taking a look? jbroman@, FYI.
3 years, 7 months ago (2017-05-25 21:33:48 UTC) #7
lazyboy
lgtm
3 years, 7 months ago (2017-05-25 21:47:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909523003/1
3 years, 7 months ago (2017-05-25 21:49:19 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 21:55:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3137d1a8be97dbc4fe14075d6145...

Powered by Google App Engine
This is Rietveld 408576698