Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2909483003: Revert of Move RedirectChromeLogging to src/chromeos. (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
Reviewers:
xiyuan, achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move RedirectChromeLogging to src/chromeos. (patchset #2 id:20001 of https://codereview.chromium.org/2901173002/ ) Reason for revert: This is causing IO failures. Specifically the SetUpSymlinkIfNeeded causes an IO assertion to hit and login to crash. Original issue's description: > Move RedirectChromeLogging to src/chromeos. > > BUG=chromium:724273 > > Review-Url: https://codereview.chromium.org/2901173002 > Cr-Commit-Position: refs/heads/master@{#474725} > Committed: https://chromium.googlesource.com/chromium/src/+/cb9bde9860d070b022407e3d988ba3239e00f35a TBR=xiyuan@chromium.org,achuith@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:724273 Review-Url: https://codereview.chromium.org/2909483003 Cr-Commit-Position: refs/heads/master@{#474770} Committed: https://chromium.googlesource.com/chromium/src/+/91f210ae83f8cc3a2cf10cd81cf0501b73067465

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -109 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/chromeos/logging.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/chromeos/logging.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/logging_chrome.h View 1 chunk +3 lines, -11 lines 0 comments Download
M chrome/common/logging_chrome.cc View 11 chunks +64 lines, -27 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
sky
Created Revert of Move RedirectChromeLogging to src/chromeos.
3 years, 7 months ago (2017-05-25 20:03:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909483003/1
3 years, 7 months ago (2017-05-25 20:03:45 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 20:04:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/91f210ae83f8cc3a2cf10cd81cf0...

Powered by Google App Engine
This is Rietveld 408576698