When deduplicating program metadata, try to use objects from the VM isolate.

When deduplicating program metadata, try to use objects from the VM isolate.

Expands the mechanism that moves token streams to the VM isolate to include instructions and code metadata.

Allow the isolate snapshot to reference Instructions in the VM isolate.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/a2695ad29b2218884ef0f0fd71f7e4e11c2932d5

[rmacnak, 2017-05-31 19:56:00]

Description was changed from

==========
When deduplicating program metadata, try to use objects from the VM isolate.
==========

to

==========
When deduplicating program metadata, try to use objects from the VM isolate.

Allow the isolate snapshot to reference Instructions in the VM isolate.
==========

[rmacnak, 2017-06-02 17:32:30]

Description was changed from

==========
When deduplicating program metadata, try to use objects from the VM isolate.

Allow the isolate snapshot to reference Instructions in the VM isolate.
==========

to

==========
When deduplicating program metadata, try to use objects from the VM isolate.

Expands the mechanism that moves token streams to the VM isolate to include
instructions and code metadata.

Allow the isolate snapshot to reference Instructions in the VM isolate.
==========

[rmacnak, 2017-06-02 17:43:34]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[rmacnak, 2017-06-02 17:43:35]

<Adding a CompileAll to the core snapshot generation>
./tools/gn.py -mrelease --gn-args=dart_core_snapshot_kind=\"core-jit\"
./tools/ninja.py -mrelease runtime
ls -hl out/ReleaseX64/gen/runtime/bin/*.bin

before
-rw-r----- 1 rmacnak eng 4.8M Jun  1 14:18
out/ReleaseX64/gen/runtime/bin/isolate_snapshot_data.bin
-rw-r----- 1 rmacnak eng 5.0M Jun  1 14:18
out/ReleaseX64/gen/runtime/bin/isolate_snapshot_instructions.bin
-rw-r----- 1 rmacnak eng 1.2M Jun  1 14:18
out/ReleaseX64/gen/runtime/bin/vm_snapshot_data.bin
-rw-r----- 1 rmacnak eng  12K Jun  1 14:18
out/ReleaseX64/gen/runtime/bin/vm_snapshot_instructions.bin
after
-rw-r----- 1 rmacnak eng 2.6M Jun  1 15:04
out/ReleaseX64/gen/runtime/bin/isolate_snapshot_data.bin
-rw-r----- 1 rmacnak eng   32 Jun  1 15:04
out/ReleaseX64/gen/runtime/bin/isolate_snapshot_instructions.bin
-rw-r----- 1 rmacnak eng 3.5M Jun  1 15:04
out/ReleaseX64/gen/runtime/bin/vm_snapshot_data.bin
-rw-r----- 1 rmacnak eng 5.1M Jun  1 15:04
out/ReleaseX64/gen/runtime/bin/vm_snapshot_instructions.bin


If using a core-jit snapshot, this reduces virtual memory. If using a core-jit
snapshot with an app-jit snapshot, this reduces virtual and physical memory and
distribution size; the same would apply to a core-aot snapshot + app-aot. No
embedders currently use any of these combinations.

[siva, 2017-06-13 02:18:06]

lgtm

[rmacnak, 2017-09-01 20:26:34]

Description was changed from

==========
When deduplicating program metadata, try to use objects from the VM isolate.

Expands the mechanism that moves token streams to the VM isolate to include
instructions and code metadata.

Allow the isolate snapshot to reference Instructions in the VM isolate.
==========

to

==========
When deduplicating program metadata, try to use objects from the VM isolate.

Expands the mechanism that moves token streams to the VM isolate to include
instructions and code metadata.

Allow the isolate snapshot to reference Instructions in the VM isolate.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a2695ad29b2218884ef0f0fd71f7e4e11c2932d5
==========

[rmacnak, 2017-09-01 20:26:36]

Committed patchset #6 (id:100001) manually as
a2695ad29b2218884ef0f0fd71f7e4e11c2932d5 (presubmit successful).