Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: runtime/vm/snapshot.h

Issue 2909403002: When deduplicating program metadata, try to use objects from the VM isolate. (Closed)
Patch Set: sync Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/program_visitor.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot.h
diff --git a/runtime/vm/snapshot.h b/runtime/vm/snapshot.h
index c374c8b11c5f65163ddee553616b20dfecab7c04..13015f8365fba5111be00f3b659f85bafd07f9f9 100644
--- a/runtime/vm/snapshot.h
+++ b/runtime/vm/snapshot.h
@@ -326,13 +326,7 @@ class BackRefNode : public ValueObject {
class ImageReader : public ZoneAllocated {
public:
- ImageReader(const uint8_t* instructions_buffer, const uint8_t* data_buffer)
- : instructions_buffer_(instructions_buffer), data_buffer_(data_buffer) {
- ASSERT(instructions_buffer != NULL);
- ASSERT(data_buffer != NULL);
- ASSERT(Utils::IsAligned(reinterpret_cast<uword>(instructions_buffer),
- OS::PreferredCodeAlignment()));
- }
+ ImageReader(const uint8_t* instructions_buffer, const uint8_t* data_buffer);
RawInstructions* GetInstructionsAt(int32_t offset);
RawObject* GetObjectAt(int32_t offset);
@@ -340,6 +334,7 @@ class ImageReader : public ZoneAllocated {
private:
const uint8_t* instructions_buffer_;
const uint8_t* data_buffer_;
+ const uint8_t* vm_instructions_buffer_;
DISALLOW_COPY_AND_ASSIGN(ImageReader);
};
« no previous file with comments | « runtime/vm/program_visitor.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698