Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2909393003: Revert of Enable redirection of SequencedWorkerPool to TaskScheduler in TestBrowserThreadBundle. (Closed)

Created:
3 years, 6 months ago by falken
Modified:
3 years, 6 months ago
Reviewers:
robliao, gab, sky, fdoray
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable redirection of SequencedWorkerPool to TaskScheduler in TestBrowserThreadBundle. (patchset #3 id:40001 of https://codereview.chromium.org/2769693002/ ) Reason for revert: Caused ServiceWorkerResourceStorageDiskTest.* tests in content_unittests to crash. See https://bugs.chromium.org/p/chromium/issues/detail?id=727994 Reverting locally fixed the crashes, so I'm going to revert this CL. Original issue's description: > Enable redirection of SequencedWorkerPool to TaskScheduler in TestBrowserThreadBundle. > > Motivation: > - Redirection of SequencedWorkerPool to TaskScheduler is enabled in > browser tests and on Canary and Dev. It makes sense to enable it > in unit tests too. > - It is not possible to wait until there are no more blocking pool > *and* TaskScheduler tasks (new tasks in the blocking pool during > a FlushForTesting() call on TaskScheduler and vice versa). If > the blocking pool is redirected to TaskScheduler, calling > FlushForTesting() on TaskScheduler guarantees that there are no > more blocking pool *and* TaskScheduler tasks. > > BUG=667892 > > Review-Url: https://codereview.chromium.org/2769693002 > Cr-Commit-Position: refs/heads/master@{#475144} > Committed: https://chromium.googlesource.com/chromium/src/+/e1aa28915a28da266d406202a07112d44d6cc018 TBR=gab@chromium.org,robliao@chromium.org,sky@chromium.org,fdoray@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=667892, 727994 Review-Url: https://codereview.chromium.org/2909393003 Cr-Commit-Position: refs/heads/master@{#475816} Committed: https://chromium.googlesource.com/chromium/src/+/2a1abaac62e57773e4abe594f1de2b19dbb83e58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/public/test/test_browser_thread_bundle.cc View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
falken
Created Revert of Enable redirection of SequencedWorkerPool to TaskScheduler in TestBrowserThreadBundle.
3 years, 6 months ago (2017-05-31 04:46:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909393003/1
3 years, 6 months ago (2017-05-31 04:46:36 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 05:48:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2a1abaac62e57773e4abe594f1de...

Powered by Google App Engine
This is Rietveld 408576698