Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2909373002: Update the updating_clang document to include copying the translation_unit tool (Closed)

Created:
3 years, 6 months ago by hans
Modified:
3 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the updating_clang document to include copying the translation_unit tool BUG=724686 Review-Url: https://codereview.chromium.org/2909373002 Cr-Commit-Position: refs/heads/master@{#475651} Committed: https://chromium.googlesource.com/chromium/src/+/6c96037e35179fdafa339ee44411c018702d82eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M docs/updating_clang.md View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hans
Please take a look.
3 years, 6 months ago (2017-05-30 19:40:34 UTC) #2
Nico
lgtm :-/
3 years, 6 months ago (2017-05-30 19:50:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909373002/1
3 years, 6 months ago (2017-05-30 19:53:42 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 20:17:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c96037e35179fdafa339ee44411...

Powered by Google App Engine
This is Rietveld 408576698