Delete PasswordStoreMac and SimplePasswordStoreMac.

Delete PasswordStoreMac and SimplePasswordStoreMac.

Keychain usage for passwords is finally deprecated. The only functional change for the users is that we stop cleaning up the passwords in Keychain. PasswordStoreMac wasn't instantiated before this CL.

BUG=466638
Review-Url: https://codereview.chromium.org/2909283002
Cr-Commit-Position: refs/heads/master@{#475547}
Committed: https://chromium.googlesource.com/chromium/src/+/efe5baba2d156238707d6d8303b2055ddb246fe2

[vasilii, 2017-05-30 12:03:16]

vasilii@chromium.org changed reviewers:
+ dvadym@chromium.org

[vasilii, 2017-05-30 12:03:17]

Hi Vadym,

please review.

[vasilii, 2017-05-30 12:03:22]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 12:03:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 12:05:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 12:05:36]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[vasilii, 2017-05-30 12:28:09]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 12:28:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 12:37:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 12:37:01]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[vasilii, 2017-05-30 12:45:02]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 12:45:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dvadym, 2017-05-30 13:01:10]

Great - >4000 Lines. LGTM

[vasilii, 2017-05-30 13:04:20]

The CQ bit was unchecked by vasilii@chromium.org

[vasilii, 2017-05-30 13:04:29]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2017-05-30 13:04:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 15:10:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 15:10:51]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[vasilii, 2017-05-30 15:21:58]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2017-05-30 15:22:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 16:08:16]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496157718440540,
"parent_rev": "6a65f61585fb64600e3d9c80d29572c2a439478b", "commit_rev":
"efe5baba2d156238707d6d8303b2055ddb246fe2"}

[commit-bot: I haz the power, 2017-05-30 16:08:25]

Description was changed from

==========
Delete PasswordStoreMac and SimplePasswordStoreMac.

Keychain usage for passwords is finally deprecated. The only functional change
for the users is that we stop cleaning up the passwords in Keychain.
PasswordStoreMac wasn't instantiated before this CL.

BUG=466638
==========

to

==========
Delete PasswordStoreMac and SimplePasswordStoreMac.

Keychain usage for passwords is finally deprecated. The only functional change
for the users is that we stop cleaning up the passwords in Keychain.
PasswordStoreMac wasn't instantiated before this CL.

BUG=466638

Review-Url: https://codereview.chromium.org/2909283002
Cr-Commit-Position: refs/heads/master@{#475547}
Committed:
https://chromium.googlesource.com/chromium/src/+/efe5baba2d156238707d6d8303b2...
==========

[commit-bot: I haz the power, 2017-05-30 16:08:27]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/efe5baba2d156238707d6d8303b2...

[vabr (Chromium), 2017-06-05 11:57:30]

\o/ Very glad to see this, cannot resist an unneeded LGTM! :D