chrome/browser/content_settings/content_settings_internal_extension_provider.cc - Issue 2909273003: Replace raw ptr from ContentSettingsPattern Builder with unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_internal_extension_provider.cc

Issue 2909273003: Replace raw ptr from ContentSettingsPattern Builder with unique_ptr (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/content_settings/content_settings_helpers.cc » ('j') | components/content_settings/core/common/content_settings_pattern.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_internal_extension_provider.cc

diff --git a/chrome/browser/content_settings/content_settings_internal_extension_provider.cc b/chrome/browser/content_settings/content_settings_internal_extension_provider.cc

index d15d0b6f470e5e94a0aa46a60b8a44cd869bff4a..b67c879a9ff1effad2f1aa173e42474b104d2ee4 100644

--- a/chrome/browser/content_settings/content_settings_internal_extension_provider.cc

+++ b/chrome/browser/content_settings/content_settings_internal_extension_provider.cc

@@ -195,8 +195,7 @@ void InternalExtensionProvider::SetContentSettingForExtensionAndResource(

const extensions::Extension* extension,

const ResourceIdentifier& resource,

ContentSetting setting) {

- std::unique_ptr<ContentSettingsPattern::BuilderInterface> pattern_builder(

- ContentSettingsPattern::CreateBuilder(false));

+ auto pattern_builder = ContentSettingsPattern::CreateBuilder();

pattern_builder->WithScheme(extensions::kExtensionScheme);

pattern_builder->WithHost(extension->id());

pattern_builder->WithPathWildcard();