chrome/browser/extensions/api/content_settings/content_settings_helpers.cc - Issue 2909273003: Replace raw ptr from ContentSettingsPattern Builder with unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/content_settings/content_settings_helpers.cc

Issue 2909273003: Replace raw ptr from ContentSettingsPattern Builder with unique_ptr (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_internal_extension_provider.cc ('k') | chrome/browser/signin/account_reconcilor_unittest.cc » ('j') | components/content_settings/core/common/content_settings_pattern.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/content_settings/content_settings_helpers.cc

diff --git a/chrome/browser/extensions/api/content_settings/content_settings_helpers.cc b/chrome/browser/extensions/api/content_settings/content_settings_helpers.cc

index c463d6dc02770beb6fa160ad734bf8cab2de4761..ea2ebe87575edd94462ce60544e667afa27a3ea0 100644

--- a/chrome/browser/extensions/api/content_settings/content_settings_helpers.cc

+++ b/chrome/browser/extensions/api/content_settings/content_settings_helpers.cc

@@ -45,8 +45,7 @@ ContentSettingsPattern ParseExtensionPattern(const std::string& pattern_str,

*error = URLPattern::GetParseResultString(result);

return ContentSettingsPattern();

} else {

- std::unique_ptr<ContentSettingsPattern::BuilderInterface> builder(

- ContentSettingsPattern::CreateBuilder(false));

+ auto builder = ContentSettingsPattern::CreateBuilder();

builder->WithHost(url_pattern.host());

if (url_pattern.match_subdomains())

builder->WithDomainWildcard();