Issue 290923003: Revert of Unconditionally include <string> and <iostream> in json_reader.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 290923003: Revert of Unconditionally include <string> and <iostream> in json_reader.cpp (Closed)

Created:
6 years, 7 months ago by Nico

Modified:
6 years, 7 months ago

Reviewers:
Ronghua Wu (Left Chromium), Mallinath (Gone from Chromium), Alexander Potapenko

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Unconditionally include <string> and <iostream> in json_reader.cpp (https://codereview.chromium.org/291803003/) Reason for revert: This adds a static initializer. Original issue's description: > Unconditionally include <string> and <iostream> in json_reader.cpp > Non-PNaCl builds that use libc++ also require these headers. > > BUG=None > R=mallinath@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271429 TBR=mallinath@chromium.org,ronghuawu@chromium.org,glider@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271446

Created: 6 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	third_party/jsoncpp/overrides/src/lib_json/json_reader.cpp	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Nico

Created Revert of Unconditionally include <string> and <iostream> in json_reader.cpp

6 years, 7 months ago (2014-05-19 19:05:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/290923003/1

6 years, 7 months ago (2014-05-19 19:05:46 UTC) #2

Message was sent while issue was closed.

Change committed as 271446