Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2909223003: Wire up Android system permission prompts in PermissionRequestManager codepath (Closed)

Created:
3 years, 6 months ago by Timothy Loh
Modified:
3 years, 6 months ago
Reviewers:
raymes
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, hiroshige+script_chromium.org, kouhei+script_chromium.org, raymes+watch_chromium.org, kochi+script_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Wire up Android system permission prompts in PermissionRequestManager codepath This patch fixes the PermissionRequestManager codepath to show Android system permission prompts where appropriate, by implementing PermissionRequestImpl::GetContentSettingsType() so we know what permission to request. BUG=606138 Review-Url: https://codereview.chromium.org/2909223003 Cr-Commit-Position: refs/heads/master@{#475790} Committed: https://chromium.googlesource.com/chromium/src/+/c136c9e35c51c4956eb0c35b9b75dc4c4b80146a

Patch Set 1 #

Patch Set 2 : w/o dependent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/permissions/permission_request_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/permissions/permission_request_impl.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Timothy Loh
3 years, 6 months ago (2017-05-30 05:35:04 UTC) #2
raymes
lgtm
3 years, 6 months ago (2017-05-31 02:45:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909223003/20001
3 years, 6 months ago (2017-05-31 03:18:44 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 04:08:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c136c9e35c51c4956eb0c35b9b75...

Powered by Google App Engine
This is Rietveld 408576698