Replace deprecated base::NonThreadSafe in chrome/browser/ui/views in favor of SequenceChecker.

Replace deprecated base::NonThreadSafe in chrome/browser/ui/views in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

(and then amended to use ThreadChecker instead for StatusTrayStateChangerWin)

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2909213002
Cr-Commit-Position: refs/heads/master@{#476397}
Committed: https://chromium.googlesource.com/chromium/src/+/2f37bf18685e1729e784fa3b5d27aeec3323c136

[gab, 2017-05-30 02:54:20]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-05-30 02:54:22]

Hi, this is an automated change made by https://crbug.com/676387#c8 and sharded
across directories for OWNERS.

No human has looked at this specific output yet, see cl description for things
to watch for.

If it LGTY, please CQ.

If it didn't pass CQ dry-run it may be a simple patch failure or an IWYU failure
from having this being a partial CL... please review anyways and a human will
look at the failure (and ping for re-review if anything major is required..). It
is known to compile all targets on Windows at r474679...  manual tweaks will
likely be required to smoothen things off, bear with me!

Thanks!
Gab

[commit-bot: I haz the power, 2017-05-30 02:54:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 03:43:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 03:43:36]

Dry run: This issue passed the CQ dry run.

[gab, 2017-05-31 18:10:00]

friendly ping, please CQ

[Peter Kasting, 2017-05-31 23:07:12]

It looks to me as if the changes in status_tray_win.cc are fine (just verifying
that that class' non-static methods are not called on the worker thread), but
maybe the StatusTrayStateChangerWin class needs to be ThreadChecker instead of
SequenceChecker (because it needs to run on the specific worker thread that's
been created for it, since that has a different COM model).

[gab, 2017-06-01 14:06:18]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in chrome/browser/ui/views in favor of
SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=pkasting@chromium.org
==========

to

==========
Replace deprecated base::NonThreadSafe in chrome/browser/ui/views in favor of
SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

(and then amended to use ThreadChecker instead for StatusTrayStateChangerWin)

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=pkasting@chromium.org
==========

[gab, 2017-06-01 14:06:42]

On 2017/05/31 23:07:12, Peter Kasting wrote:
> It looks to me as if the changes in status_tray_win.cc are fine (just
verifying
> that that class' non-static methods are not called on the worker thread), but
> maybe the StatusTrayStateChangerWin class needs to be ThreadChecker instead of
> SequenceChecker (because it needs to run on the specific worker thread that's
> been created for it, since that has a different COM model).

Done.

[gab, 2017-06-01 14:06:57]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 14:07:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 15:00:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 15:00:57]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2017-06-01 19:41:41]

LGTM

[gab, 2017-06-01 19:49:17]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-06-01 19:49:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 19:54:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496346557739560,
"parent_rev": "a8814672c6782eeb7bbf080bbc84026fefc17c85", "commit_rev":
"2f37bf18685e1729e784fa3b5d27aeec3323c136"}

[commit-bot: I haz the power, 2017-06-01 19:55:00]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in chrome/browser/ui/views in favor of
SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

(and then amended to use ThreadChecker instead for StatusTrayStateChangerWin)

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=pkasting@chromium.org
==========

to

==========
Replace deprecated base::NonThreadSafe in chrome/browser/ui/views in favor of
SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

(and then amended to use ThreadChecker instead for StatusTrayStateChangerWin)

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2909213002
Cr-Commit-Position: refs/heads/master@{#476397}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f37bf18685e1729e784fa3b5d27...
==========

[commit-bot: I haz the power, 2017-06-01 19:55:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2f37bf18685e1729e784fa3b5d27...