Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2909203003: DOMTokenList: Fold AddInternal() and RemoveInternal() into toggle(). (Closed)

Created:
3 years, 6 months ago by tkent
Modified:
3 years, 6 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DOMTokenList: Fold AddInternal() and RemoveInternal() into toggle(). Only toggle() uses AddInternal() and RemoveInternal(). This CL folds them into toggle(), and update toggle() code to follow the DOM specification. This CL doesn't change any behavior. BUG=726214 Review-Url: https://codereview.chromium.org/2909203003 Cr-Commit-Position: refs/heads/master@{#475440} Committed: https://chromium.googlesource.com/chromium/src/+/eff1abada903178a950e2c2587f227356cff584d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M third_party/WebKit/Source/core/dom/DOMTokenList.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMTokenList.cpp View 2 chunks +21 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tkent
kochi@, would you review this please?
3 years, 6 months ago (2017-05-30 05:52:22 UTC) #5
kochi
LGTM The spec itself is very confusing to me, esp. "force" parameter :)
3 years, 6 months ago (2017-05-30 06:16:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909203003/1
3 years, 6 months ago (2017-05-30 06:23:40 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 06:27:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eff1abada903178a950e2c2587f2...

Powered by Google App Engine
This is Rietveld 408576698