Replace deprecated base::NonThreadSafe in chrome/browser/chromeos in favor of SequenceChecker.

Replace deprecated base::NonThreadSafe in chrome/browser/chromeos in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=achuith@chromium.org

Review-Url: https://codereview.chromium.org/2909203002
Cr-Commit-Position: refs/heads/master@{#476003}
Committed: https://chromium.googlesource.com/chromium/src/+/d9279f0c0358aa6492a7a271e651eabe5e0f5086

[gab, 2017-05-30 02:52:44]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-05-30 02:52:46]

Hi, this is an automated change made by https://crbug.com/676387#c8 and sharded
across directories for OWNERS.

No human has looked at this specific output yet, see cl description for things
to watch for.

If it LGTY, please CQ.

If it didn't pass CQ dry-run it may be a simple patch failure or an IWYU failure
from having this being a partial CL... please review anyways and a human will
look at the failure (and ping for re-review if anything major is required..). It
is known to compile all targets on Windows at r474679...  manual tweaks will
likely be required to smoothen things off, bear with me!

Thanks!
Gab

[commit-bot: I haz the power, 2017-05-30 02:53:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 04:13:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 04:13:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[achuithb, 2017-05-30 19:17:22]

lgtm

[achuithb, 2017-05-30 19:18:23]

Actually tests fail, so you cannot land this.

[gab, 2017-05-31 18:13:27]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 18:14:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-05-31 18:17:05]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 18:17:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-05-31 18:19:38]

On 2017/05/30 19:18:23, achuithb wrote:
> Actually tests fail, so you cannot land this.

The issue was

#4 0x000001afe642 chromeos::NetworkPortalDetectorImpl::RemoveObserver()
#5 0x000001b01d73
chromeos::NetworkPortalNotificationController::~NetworkPortalNotificationController()
#6 0x000001b01e5e
chromeos::NetworkPortalNotificationController::~NetworkPortalNotificationController()
#7 0x000001afe082
chromeos::NetworkPortalDetectorImpl::~NetworkPortalDetectorImpl()
#8 0x000001afe3ce
chromeos::NetworkPortalDetectorImpl::~NetworkPortalDetectorImpl()

which resulted in a user-after-free on |sequence_checker_|. Re-ordered
|sequence_checker_| member above |notification_controller_| member to solve this
in place.

I'll leave it up to you and co-owners to come up with a better solution if that
just highlighted a weird dependency cycle for you.

Thanks!

[gab, 2017-05-31 18:19:56]

The CQ bit was unchecked by gab@chromium.org

[gab, 2017-05-31 18:20:01]

The CQ bit was checked by gab@chromium.org

[gab, 2017-05-31 18:20:01]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2909203002/#ps20001
(title: "fix member order")

[commit-bot: I haz the power, 2017-05-31 18:20:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 20:36:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496254801131630,
"parent_rev": "126e33d8b030ec43e0d1fe3a458da747c30bb7ab", "commit_rev":
"d9279f0c0358aa6492a7a271e651eabe5e0f5086"}

[commit-bot: I haz the power, 2017-05-31 20:36:38]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in chrome/browser/chromeos in favor of
SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=achuith@chromium.org
==========

to

==========
Replace deprecated base::NonThreadSafe in chrome/browser/chromeos in favor of
SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=achuith@chromium.org

Review-Url: https://codereview.chromium.org/2909203002
Cr-Commit-Position: refs/heads/master@{#476003}
Committed:
https://chromium.googlesource.com/chromium/src/+/d9279f0c0358aa6492a7a271e651...
==========

[commit-bot: I haz the power, 2017-05-31 20:36:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d9279f0c0358aa6492a7a271e651...