Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2909193002: Replace deprecated base::NonThreadSafe in chrome/browser/prerender in favor of SequenceChecker. (Closed)

Created:
3 years, 6 months ago by gab
Modified:
3 years, 6 months ago
Reviewers:
davidben
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace deprecated base::NonThreadSafe in chrome/browser/prerender in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=davidben@chromium.org Review-Url: https://codereview.chromium.org/2909193002 Cr-Commit-Position: refs/heads/master@{#475556} Committed: https://chromium.googlesource.com/chromium/src/+/e78de22c51a073429e5cfdbebd74809cd4aaa3e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/prerender/prerender_history.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_history.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
gab
Hi, this is an automated change made by https://crbug.com/676387#c8 and sharded across directories for OWNERS. ...
3 years, 6 months ago (2017-05-30 02:44:00 UTC) #2
davidben
lgtm
3 years, 6 months ago (2017-05-30 16:40:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909193002/1
3 years, 6 months ago (2017-05-30 16:41:08 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 16:45:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e78de22c51a073429e5cfdbebd74...

Powered by Google App Engine
This is Rietveld 408576698