Replace deprecated base::NonThreadSafe in content in favor of SequenceChecker.

Replace deprecated base::NonThreadSafe in content in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=nasko@chromium.org

Review-Url: https://codereview.chromium.org/2909053003
Cr-Commit-Position: refs/heads/master@{#475526}
Committed: https://chromium.googlesource.com/chromium/src/+/a05726ef77312a57e1c392b8dac943abb0d97dc1

[gab, 2017-05-30 02:32:10]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-05-30 02:32:13]

Hi, this is an automated change made by https://crbug.com/676387#c8 and sharded
across directories for OWNERS.

No human has looked at this specific output yet, see cl description for things
to watch for.

If it LGTY, please CQ.

If it didn't pass CQ dry-run it may be a simple patch failure or an IWYU failure
from having this being a partial CL... please review anyways and a human will
look at the failure (and ping for re-review if anything major is required..). It
is known to compile all targets on Windows at r474679...  manual tweaks will
likely be required to smoothen things off, bear with me!

Thanks!
Gab

[commit-bot: I haz the power, 2017-05-30 02:32:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-05-30 02:56:39]

gab@chromium.org changed reviewers:
+ avi@chromium.org
- nasko@chromium.org

[gab, 2017-05-30 02:56:40]

s/nasko (OOO)/avi/

Thanks!

[Avi (use Gerrit), 2017-05-30 03:08:51]

This fails to compile:

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2...

[34814/39429] CXX obj/chrome/browser/browser_2/jumplist_factory.obj
FAILED: obj/chrome/browser/browser_2/jumplist_factory.obj 
E:\b\c\goma_client/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC @obj/chrome/browser/browser_2/jumplist_factory.obj.rsp /c
../../chrome/browser/win/jumplist_factory.cc
/Foobj/chrome/browser/browser_2/jumplist_factory.obj
/Fd"obj/chrome/browser/browser_2_cc.pdb"
In file included from ../../chrome/browser/win/jumplist_factory.cc:5:
In file included from ../..\chrome/browser/win/jumplist_factory.h:9:
E:\b\c\b\win\src\chrome\browser\win\jumplist.h(68,31):  error: expected class
name
                 public base::NonThreadSafe {
                              ^
1 error generated.

This is not likely a flake.

[gab, 2017-05-30 03:11:59]

On 2017/05/30 03:08:51, Avi (ping after 24h) wrote:
> This fails to compile:
> 
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2...
> 
> [34814/39429] CXX obj/chrome/browser/browser_2/jumplist_factory.obj
> FAILED: obj/chrome/browser/browser_2/jumplist_factory.obj 
> E:\b\c\goma_client/gomacc.exe
> ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
> /showIncludes /FC @obj/chrome/browser/browser_2/jumplist_factory.obj.rsp /c
> ../../chrome/browser/win/jumplist_factory.cc
> /Foobj/chrome/browser/browser_2/jumplist_factory.obj
> /Fd"obj/chrome/browser/browser_2_cc.pdb"
> In file included from ../../chrome/browser/win/jumplist_factory.cc:5:
> In file included from ../..\chrome/browser/win/jumplist_factory.h:9:
> E:\b\c\b\win\src\chrome\browser\win\jumplist.h(68,31):  error: expected class
> name
>                  public base::NonThreadSafe {
>                               ^
> 1 error generated.
> 
> This is not likely a flake.

IWYU is hard... jumplist.h  was doing it wrong but it will be irrelevant after
https://codereview.chromium.org/2911133002/, please review this regardless, will
land after that one lands.

Thanks!

[Avi (use Gerrit), 2017-05-30 03:14:58]

LGTM assuming the IWYU makes it turn green.

[commit-bot: I haz the power, 2017-05-30 03:22:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 03:22:52]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[gab, 2017-05-30 14:00:24]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-05-30 14:00:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 15:04:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496152824152850, "parent_rev":
"8342ede4675b43769aa85569ee216e63b0efa39b", "commit_rev":
"a05726ef77312a57e1c392b8dac943abb0d97dc1"}

[commit-bot: I haz the power, 2017-05-30 15:05:05]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in content in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=nasko@chromium.org
==========

to

==========
Replace deprecated base::NonThreadSafe in content in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=nasko@chromium.org

Review-Url: https://codereview.chromium.org/2909053003
Cr-Commit-Position: refs/heads/master@{#475526}
Committed:
https://chromium.googlesource.com/chromium/src/+/a05726ef77312a57e1c392b8dac9...
==========

[commit-bot: I haz the power, 2017-05-30 15:05:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a05726ef77312a57e1c392b8dac9...