Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2909003002: Add gpu::BufferBacking::shared_memory_handle() (Closed)

Created:
3 years, 6 months ago by hajimehoshi
Modified:
3 years, 6 months ago
Reviewers:
jbauman
CC:
chromium-reviews, piman+watch_chromium.org, erikchen, Primiano Tucci (use gerrit), ssid
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gpu::BufferBacking::shared_memory_handle() This CL adds a base::SharedMemoryHandle getter to gpu::BufferBacking. The getter will be used by gpu::BufferBacking users when OnMemoryDump is called to create base::SharedMemory dumps. This is part of work for exposing SharedMemory usages on tracing memory-infra dumps. Design doc: https://docs.google.com/document/d/16Mi5_puxKgQ-9IX7ANfbji0WiqBCK3yrnJ0Qi2wa3w0/edit#heading=h.lofdeze1a2hr Note: This can conflict with https://codereview.chromium.org/2912723002/ BUG=604726 TEST=gpu_unittests --gtest_filter=Buffer.* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2909003002 Cr-Commit-Position: refs/heads/master@{#475837} Committed: https://chromium.googlesource.com/chromium/src/+/394636a1dbb10af27400f21b0326daedb3b6fede

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2 lines) Patch
M gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/buffer.h View 3 chunks +7 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/buffer.cc View 2 chunks +9 lines, -0 lines 0 comments Download
A gpu/command_buffer/common/buffer_unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
hajimehoshi
PTAL
3 years, 6 months ago (2017-05-29 10:12:08 UTC) #6
jbauman
lgtm
3 years, 6 months ago (2017-05-30 22:13:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909003002/1
3 years, 6 months ago (2017-05-31 04:16:50 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/226964)
3 years, 6 months ago (2017-05-31 05:42:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909003002/1
3 years, 6 months ago (2017-05-31 05:51:00 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 07:18:57 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/394636a1dbb10af27400f21b0326...

Powered by Google App Engine
This is Rietveld 408576698