Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2908953002: Update generated proto code for eventlogging (Closed)

Created:
3 years, 6 months ago by mcgreevy
Modified:
3 years, 6 months ago
Reviewers:
mcgreevy_g, mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Log build information from exparchive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+692 lines, -483 lines) Patch
M client/cmd/isolate/exp_archive.go View 1 4 chunks +32 lines, -6 lines 0 comments Download
M common/eventlog/proto/chrome_infra_log.pb.go View 10 chunks +344 lines, -309 lines 0 comments Download
M common/eventlog/proto/goma_stats.pb.go View 22 chunks +297 lines, -145 lines 0 comments Download
M common/eventlog/proto/log_request_lite.pb.go View 2 chunks +19 lines, -23 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
mcgreevy
3 years, 6 months ago (2017-05-29 06:21:25 UTC) #2
mithro
LGTM This seems to be generated and a looking over everything it seems like it ...
3 years, 6 months ago (2017-05-29 06:32:03 UTC) #3
mcgreevy
https://codereview.chromium.org/2908953002/diff/1/common/eventlog/proto/chrome_infra_log.pb.go File common/eventlog/proto/chrome_infra_log.pb.go (right): https://codereview.chromium.org/2908953002/diff/1/common/eventlog/proto/chrome_infra_log.pb.go#newcode11 common/eventlog/proto/chrome_infra_log.pb.go:11: log_request_lite.proto On 2017/05/29 06:32:02, mithro wrote: > Any idea ...
3 years, 6 months ago (2017-05-29 06:39:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908953002/1
3 years, 6 months ago (2017-05-29 06:40:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/luci-go/commit/b825bbbad14b03e5ed28b113dba99fb0d41735ad
3 years, 6 months ago (2017-05-29 06:44:21 UTC) #13
mcgreevy
please ignore patchset 2.
3 years, 6 months ago (2017-05-31 01:51:10 UTC) #14
mithro
3 years, 6 months ago (2017-05-31 02:21:54 UTC) #15
Message was sent while issue was closed.
On 2017/05/31 01:51:10, mcgreevy wrote:
> please ignore patchset 2.

You can delete it by clicking the "Delete" link on the patchset if you want.

Powered by Google App Engine
This is Rietveld 408576698