Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2908893002: [Chromecast] Make MultizoneBackendTest work on AMP devices. (Closed)

Created:
3 years, 6 months ago by jameswest
Modified:
3 years, 6 months ago
Reviewers:
slan, halliwell, kmackay
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Make MultizoneBackendTest work on AMP devices. BUG=internal b/27694837 TEST=cast_media_unittests Review-Url: https://codereview.chromium.org/2908893002 Cr-Commit-Position: refs/heads/master@{#475707} Committed: https://chromium.googlesource.com/chromium/src/+/74d1aa60c291dcdb931025060f483b4e35a5daf1

Patch Set 1 #

Total comments: 6

Patch Set 2 : Change number of seconds back to int. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -98 lines) Patch
M chromecast/media/cma/backend/multizone_backend_unittest.cc View 1 17 chunks +94 lines, -98 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jameswest
3 years, 6 months ago (2017-05-27 03:14:18 UTC) #3
kmackay
https://codereview.chromium.org/2908893002/diff/1/chromecast/media/cma/backend/multizone_backend_unittest.cc File chromecast/media/cma/backend/multizone_backend_unittest.cc (right): https://codereview.chromium.org/2908893002/diff/1/chromecast/media/cma/backend/multizone_backend_unittest.cc#newcode46 chromecast/media/cma/backend/multizone_backend_unittest.cc:46: const int64_t kPushTimeUs = 2.0 * base::Time::kMicrosecondsPerSecond; Why 2.0 ...
3 years, 6 months ago (2017-05-27 04:13:57 UTC) #4
jameswest
https://codereview.chromium.org/2908893002/diff/1/chromecast/media/cma/backend/multizone_backend_unittest.cc File chromecast/media/cma/backend/multizone_backend_unittest.cc (right): https://codereview.chromium.org/2908893002/diff/1/chromecast/media/cma/backend/multizone_backend_unittest.cc#newcode46 chromecast/media/cma/backend/multizone_backend_unittest.cc:46: const int64_t kPushTimeUs = 2.0 * base::Time::kMicrosecondsPerSecond; On 2017/05/27 ...
3 years, 6 months ago (2017-05-30 21:25:52 UTC) #5
kmackay
lgtm
3 years, 6 months ago (2017-05-30 21:28:29 UTC) #6
kmackay
3 years, 6 months ago (2017-05-30 21:28:44 UTC) #8
halliwell
On 2017/05/30 21:28:44, kmackay wrote: lgtm
3 years, 6 months ago (2017-05-30 23:57:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908893002/20001
3 years, 6 months ago (2017-05-31 00:25:54 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 00:39:29 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/74d1aa60c291dcdb931025060f48...

Powered by Google App Engine
This is Rietveld 408576698