[Chromecast] Make MultizoneBackendTest work on AMP devices.

[Chromecast] Make MultizoneBackendTest work on AMP devices.

BUG=internal b/27694837
TEST=cast_media_unittests

Review-Url: https://codereview.chromium.org/2908893002
Cr-Commit-Position: refs/heads/master@{#475707}
Committed: https://chromium.googlesource.com/chromium/src/+/74d1aa60c291dcdb931025060f483b4e35a5daf1

[jameswest, 2017-05-27 03:14:09]

Description was changed from

==========
[Chromecast] Make MultizoneBackendTest work on AMP devices.

BUG=internal b/27694837
TEST=cast_media_unittests
==========

to

==========
[Chromecast] Make MultizoneBackendTest work on AMP devices.

BUG=internal b/27694837
TEST=cast_media_unittests
==========

[jameswest, 2017-05-27 03:14:09]

jameswest@google.com changed reviewers:
+ halliwell@chromium.org, kmackay@chromium.org

[kmackay, 2017-05-27 04:13:57]

https://codereview.chromium.org/2908893002/diff/1/chromecast/media/cma/backen...
File chromecast/media/cma/backend/multizone_backend_unittest.cc (right):

https://codereview.chromium.org/2908893002/diff/1/chromecast/media/cma/backen...
chromecast/media/cma/backend/multizone_backend_unittest.cc:46: const int64_t
kPushTimeUs = 2.0 * base::Time::kMicrosecondsPerSecond;
Why 2.0 (instead of just 2)?

https://codereview.chromium.org/2908893002/diff/1/chromecast/media/cma/backen...
chromecast/media/cma/backend/multizone_backend_unittest.cc:322:
config.sample_format = kSampleFormatPlanarF32;
What was the reason for changing the sample format?

https://codereview.chromium.org/2908893002/diff/1/chromecast/media/cma/backen...
chromecast/media/cma/backend/multizone_backend_unittest.cc:375:
Initialize(sample_rate, 1 /* playback_rate_change_count */);
Note that now, we are only testing a sample rate transition from 1.0 to 0.5 and
back. We should also test 1.0 to 2.0 and back, as well as < 1 to > 1 and back.

[jameswest, 2017-05-30 21:25:52]

https://codereview.chromium.org/2908893002/diff/1/chromecast/media/cma/backen...
File chromecast/media/cma/backend/multizone_backend_unittest.cc (right):

https://codereview.chromium.org/2908893002/diff/1/chromecast/media/cma/backen...
chromecast/media/cma/backend/multizone_backend_unittest.cc:46: const int64_t
kPushTimeUs = 2.0 * base::Time::kMicrosecondsPerSecond;
On 2017/05/27 04:13:56, kmackay wrote:
> Why 2.0 (instead of just 2)?

I changed it to 0.5 while testing and changed it back to 2.0 by mistake.

https://codereview.chromium.org/2908893002/diff/1/chromecast/media/cma/backen...
chromecast/media/cma/backend/multizone_backend_unittest.cc:322:
config.sample_format = kSampleFormatPlanarF32;
On 2017/05/27 04:13:56, kmackay wrote:
> What was the reason for changing the sample format?

I changed it to kSampleFormatS32 in https://codereview.chromium.org/2074473002/
because the AMP backend didn't support kSampleFormatPlanarF32. Now that I've
changed the AMP backend to support it, I'm changing it back.

https://codereview.chromium.org/2908893002/diff/1/chromecast/media/cma/backen...
chromecast/media/cma/backend/multizone_backend_unittest.cc:375:
Initialize(sample_rate, 1 /* playback_rate_change_count */);
On 2017/05/27 04:13:56, kmackay wrote:
> Note that now, we are only testing a sample rate transition from 1.0 to 0.5
and
> back. We should also test 1.0 to 2.0 and back, as well as < 1 to > 1 and back.

This preserves the previous behavior where it changes the playback rate once.

[kmackay, 2017-05-30 21:28:29]

lgtm

[kmackay, 2017-05-30 21:28:43]

kmackay@chromium.org changed reviewers:
+ slan@chromium.org

[halliwell, 2017-05-30 23:57:20]

On 2017/05/30 21:28:44, kmackay wrote:

lgtm

[jameswest, 2017-05-31 00:24:48]

The CQ bit was checked by jameswest@google.com

[commit-bot: I haz the power, 2017-05-31 00:25:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 00:39:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496190288302030,
"parent_rev": "f8ced1a33c4c82e224427dc7d7433582cc183600", "commit_rev":
"74d1aa60c291dcdb931025060f483b4e35a5daf1"}

[commit-bot: I haz the power, 2017-05-31 00:39:27]

Description was changed from

==========
[Chromecast] Make MultizoneBackendTest work on AMP devices.

BUG=internal b/27694837
TEST=cast_media_unittests
==========

to

==========
[Chromecast] Make MultizoneBackendTest work on AMP devices.

BUG=internal b/27694837
TEST=cast_media_unittests

Review-Url: https://codereview.chromium.org/2908893002
Cr-Commit-Position: refs/heads/master@{#475707}
Committed:
https://chromium.googlesource.com/chromium/src/+/74d1aa60c291dcdb931025060f48...
==========

[commit-bot: I haz the power, 2017-05-31 00:39:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/74d1aa60c291dcdb931025060f48...