Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2908843002: Rename "service_unittests" -> "services_unittests". (Closed)

Created:
3 years, 7 months ago by Elliot Glaysher
Modified:
3 years, 6 months ago
CC:
chromium-reviews, James Cook
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename "service_unittests" -> "services_unittests". Test suites are supposed to have the same name as the directory they're in; also this test target doesn't test a single service, it tests multiple. BUG=722546 Review-Url: https://codereview.chromium.org/2908843002 Cr-Commit-Position: refs/heads/master@{#475192} Committed: https://chromium.googlesource.com/chromium/src/+/cd559ca9b161b9bf1cf77b7f387faf4f6616c945

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -44 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M testing/buildbot/chromium.android.json View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +3 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 16 chunks +16 lines, -16 lines 1 comment Download
M testing/buildbot/chromium.linux.json View 4 chunks +4 lines, -4 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +5 lines, -5 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +4 lines, -4 lines 0 comments Download
M testing/buildbot/client.v8.chromium.json View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
Elliot Glaysher
this should be it! the services test reorg should be all done now! sky: review ...
3 years, 7 months ago (2017-05-26 22:24:37 UTC) #4
sky
LGTM
3 years, 7 months ago (2017-05-26 22:52:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908843002/1
3 years, 7 months ago (2017-05-26 23:39:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cd559ca9b161b9bf1cf77b7f387faf4f6616c945
3 years, 7 months ago (2017-05-26 23:43:54 UTC) #12
Ken Russell (Google)
3 years, 6 months ago (2017-06-22 00:13:01 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/2908843002/diff/1/testing/buildbot/chromium.g...
File testing/buildbot/chromium.gpu.fyi.json (left):

https://codereview.chromium.org/2908843002/diff/1/testing/buildbot/chromium.g...
testing/buildbot/chromium.gpu.fyi.json:5568: "test": "service_unittests",
Nit: this file is autogenerated, per the header. I'll fix up the generator
script.

Powered by Google App Engine
This is Rietveld 408576698