Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2908833002: Revert "Revert "Refactor test option parsing code."" (Closed)

Created:
3 years, 7 months ago by Bob Nystrom
Modified:
3 years, 7 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Bill Hesse
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "Refactor test option parsing code."" This reverts commit d03835783ca866be10802a7411a85804ae263a1d. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/79af4184306a568ee8f006b9f0eaeab6ebae7750

Patch Set 1 #

Patch Set 2 : Ignore "—failure-summary" so it doesn't break the bots. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+940 lines, -1048 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -3 lines 0 comments Download
M samples/samples.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/testing/dart/co19_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 12 chunks +14 lines, -15 lines 0 comments Download
M tools/testing/dart/main.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A tools/testing/dart/options.dart View 1 1 chunk +916 lines, -0 lines 1 comment Download
M tools/testing/dart/package_testing_support.dart View 1 chunk +4 lines, -6 lines 0 comments Download
D tools/testing/dart/test_options.dart View 1 chunk +0 lines, -1012 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Bob Nystrom
The first patch set is the code that was already landed and reverted. You can ...
3 years, 7 months ago (2017-05-26 21:12:35 UTC) #2
Emily Fortuna
lgtm https://codereview.chromium.org/2908833002/diff/20001/tools/testing/dart/options.dart File tools/testing/dart/options.dart (right): https://codereview.chromium.org/2908833002/diff/20001/tools/testing/dart/options.dart#newcode401 tools/testing/dart/options.dart:401: // TODO(rnystrom): The builders on the buildbots still ...
3 years, 7 months ago (2017-05-26 21:17:36 UTC) #3
Bob Nystrom
On 2017/05/26 21:17:36, Emily Fortuna wrote: > lgtm > > https://codereview.chromium.org/2908833002/diff/20001/tools/testing/dart/options.dart > File tools/testing/dart/options.dart (right): ...
3 years, 7 months ago (2017-05-26 21:18:02 UTC) #4
Bob Nystrom
3 years, 7 months ago (2017-05-26 21:18:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
79af4184306a568ee8f006b9f0eaeab6ebae7750 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698