Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 2908833002: Revert "Revert "Refactor test option parsing code."" (Closed)
Patch Set: Ignore "—failure-summary" so it doesn't break the bots. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/testing/dart/options.dart ('K') | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 08362f36542656717f986f372c4cf43de31e5247..cf0af89723d035f20ea31a7eeaff8d78bbad2c2a 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -474,7 +474,7 @@ class CCTestSuite extends TestSuite {
var args = TestUtils.standardOptions(configuration);
var compilerConfiguration = new CompilerConfiguration(configuration);
- if (compilerConfiguration.useDFE) {
+ if (compilerConfiguration.useDfe) {
args.add('--use-dart-frontend');
// '--dfe' has to be the first argument for run_vm_test to pick it up.
args.insert(0, '--dfe=$buildDir/gen/kernel-service.dart.snapshot');
@@ -2028,9 +2028,6 @@ class TestUtils {
if (compiler == "dart2js" && configuration["csp"]) {
args.add("--csp");
}
- if (compiler == "dart2js" && configuration["cps_ir"]) {
- args.add("--use-cps-ir");
- }
if (compiler == "dart2js" && configuration["fast_startup"]) {
args.add("--fast-startup");
}
« tools/testing/dart/options.dart ('K') | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698