Change HpackHuffmanDecoder::CanonicalToSource() return type.

Change HpackHuffmanDecoder::CanonicalToSource() return type.

This is to avoid casting uint8 to char to unsigned char to uint16:
one cast (from uint8 to uint16) should be enough.

This lands internal change 157244049 by bnc.

BUG=488484
Review-Url: https://codereview.chromium.org/2908763002
Cr-Commit-Position: refs/heads/master@{#475114}
Committed: https://chromium.googlesource.com/chromium/src/+/9b7060c78d0c6ec8f831823bf9fff9946eece7d4

[Bence, 2017-05-26 16:45:01]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 16:45:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 18:20:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 18:20:34]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-05-26 18:28:10]

bnc@chromium.org changed reviewers:
+ dahollings@chromium.org

[Bence, 2017-05-26 18:28:11]

dahollings: PTAL.  Thank you.

[dahollings, 2017-05-26 18:33:40]

The CQ bit was checked by dahollings@chromium.org

[dahollings, 2017-05-26 18:33:41]

lgtm

[commit-bot: I haz the power, 2017-05-26 18:34:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 18:34:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 18:34:35]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Bence, 2017-05-26 18:37:08]

bnc@chromium.org changed reviewers:
+ xunjieli@chromium.org

[Bence, 2017-05-26 18:37:09]

xunjieli: please rubber stamp.  Thank you.

[Bence, 2017-05-26 18:38:04]

Description was changed from

==========
Change HpackHuffmanDecoder::CanonicalToSource() return type.

This is to avoid casting uint8 to char to unsigned char to uint16:
one cast (from uint8 to uint16) should be enough.

This lands internal change 157229864 by bnc.

BUG=488484
==========

to

==========
Change HpackHuffmanDecoder::CanonicalToSource() return type.

This is to avoid casting uint8 to char to unsigned char to uint16:
one cast (from uint8 to uint16) should be enough.

This lands internal change 157244049 by bnc.

BUG=488484
==========

[xunjieli, 2017-05-26 18:54:20]

lgtm

https://codereview.chromium.org/2908763002/diff/1/net/spdy/core/hpack/hpack_h...
File net/spdy/core/hpack/hpack_huffman_decoder.h (right):

https://codereview.chromium.org/2908763002/diff/1/net/spdy/core/hpack/hpack_h...
net/spdy/core/hpack/hpack_huffman_decoder.h:60: // Converts a canonical symbol
to the source symbol (the char in the original
nit: comment still mentions "char"

[Bence, 2017-05-26 18:57:41]

The CQ bit was checked by bnc@chromium.org

[Bence, 2017-05-26 18:57:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
dahollings@chromium.org, xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/2908763002/#ps20001
(title: "Re: #15.")

[Bence, 2017-05-26 18:57:50]

Thank you both for reviewing.

https://codereview.chromium.org/2908763002/diff/1/net/spdy/core/hpack/hpack_h...
File net/spdy/core/hpack/hpack_huffman_decoder.h (right):

https://codereview.chromium.org/2908763002/diff/1/net/spdy/core/hpack/hpack_h...
net/spdy/core/hpack/hpack_huffman_decoder.h:60: // Converts a canonical symbol
to the source symbol (the char in the original
On 2017/05/26 18:54:20, xunjieli wrote:
> nit: comment still mentions "char"

Done.

My understanding is that "char" refers to character (as "letter") as opposed to
a particular data type.  Changing to octet to align with language of RFC instead
of changing to uint8_t which looks a bit awkward.

[commit-bot: I haz the power, 2017-05-26 18:58:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 20:38:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495825061422340,
"parent_rev": "02aedd51c645b857f65b18d38ba5e5d3f8aed015", "commit_rev":
"9b7060c78d0c6ec8f831823bf9fff9946eece7d4"}

[commit-bot: I haz the power, 2017-05-26 20:38:47]

Description was changed from

==========
Change HpackHuffmanDecoder::CanonicalToSource() return type.

This is to avoid casting uint8 to char to unsigned char to uint16:
one cast (from uint8 to uint16) should be enough.

This lands internal change 157244049 by bnc.

BUG=488484
==========

to

==========
Change HpackHuffmanDecoder::CanonicalToSource() return type.

This is to avoid casting uint8 to char to unsigned char to uint16:
one cast (from uint8 to uint16) should be enough.

This lands internal change 157244049 by bnc.

BUG=488484

Review-Url: https://codereview.chromium.org/2908763002
Cr-Commit-Position: refs/heads/master@{#475114}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b7060c78d0c6ec8f831823bf9ff...
==========

[commit-bot: I haz the power, 2017-05-26 20:38:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9b7060c78d0c6ec8f831823bf9ff...