Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2908703003: chromeos: make mash session not launch chrome (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: make mash session not launch chrome Doing this causes problems with ash_standalone as well as tests. In particular it means ash_standalone attempts to connect to chrome and then chrome tries to connect as the window manager. For tests it can cause hangs. BUG=721901 TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2908703003 Cr-Commit-Position: refs/heads/master@{#475064} Committed: https://chromium.googlesource.com/chromium/src/+/e7d345c67a7b4bb98e8c7c0fed1f37d316acd867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M mash/session/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/session/session.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sky
3 years, 7 months ago (2017-05-26 15:35:55 UTC) #1
msw
This doesn't affect chrome --mash, right? If not, lgtm.
3 years, 7 months ago (2017-05-26 16:40:54 UTC) #4
sky
On 2017/05/26 16:40:54, msw wrote: > This doesn't affect chrome --mash, right? If not, lgtm. ...
3 years, 7 months ago (2017-05-26 17:23:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908703003/1
3 years, 7 months ago (2017-05-26 17:24:38 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 18:25:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7d345c67a7b4bb98e8c7c0fed1f...

Powered by Google App Engine
This is Rietveld 408576698