ios/clean/chrome/browser/ui/toolbar/toolbar_consumer.h - Issue 2908623004: [ios clean] Toolbar displays total number of tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/clean/chrome/browser/ui/toolbar/toolbar_consumer.h

Issue 2908623004: [ios clean] Toolbar displays total number of tabs. (Closed)

Patch Set: Minor comment changes. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/clean/chrome/browser/ui/toolbar/toolbar_consumer.h

diff --git a/ios/clean/chrome/browser/ui/toolbar/toolbar_consumer.h b/ios/clean/chrome/browser/ui/toolbar/toolbar_consumer.h

index 2e9a4453637a18e18b99f9cefad6ee7b73414963..1dc58ddeab94d98615f4cc3ac352aab8bcfa3987 100644

--- a/ios/clean/chrome/browser/ui/toolbar/toolbar_consumer.h

+++ b/ios/clean/chrome/browser/ui/toolbar/toolbar_consumer.h

@@ -17,6 +17,8 @@

- (void)setIsLoading:(BOOL)isLoading;

// Updates the toolbar with the current progress of the loading WebState.

- (void)setLoadingProgress:(double)progress;

+// Updates the toolbar with the current number of total webstates.

marq (ping after 24h) 2017/05/29 11:04:36 Nit: Total number of tabs. The consumer doesn't kn

sczs 2017/05/30 00:18:21 Done.

+- (void)setNumberOfTabs:(int)numberOfTabs;

edchin 2017/05/27 16:25:06 nit: what's more common? numberOfThings or thingsC

sczs 2017/05/30 00:18:21 You're right, tabCount is much better! Changed it

@end

#endif // IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_CONSUMER_H_