ios/clean/chrome/browser/ui/toolbar/toolbar_consumer.h - Issue 2908623004: [ios clean] Toolbar displays total number of tabs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/toolbar/toolbar_consumer.h

Issue 2908623004: [ios clean] Toolbar displays total number of tabs. (Closed)

Patch Set: Minor comment changes. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/clean/chrome/browser/ui/toolbar/toolbar_constants.mm ('K') | « ios/clean/chrome/browser/ui/toolbar/toolbar_constants.mm ('k') | ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm » ('j') | ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_CONSUMER_H_	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_CONSUMER_H_

6 #define IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_CONSUMER_H_	6 #define IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_CONSUMER_H_

7	7

8 #import <UIKit/UIKit.h>	8 #import <UIKit/UIKit.h>

9	9

10 // ToolbarConsumer sets the current appearance of the Toolbar.	10 // ToolbarConsumer sets the current appearance of the Toolbar.

11 @protocol ToolbarConsumer	11 @protocol ToolbarConsumer

12 // Updates the toolbar with the current forward navigation state.	12 // Updates the toolbar with the current forward navigation state.

13 - (void)setCanGoForward:(BOOL)canGoForward;	13 - (void)setCanGoForward:(BOOL)canGoForward;

14 // Updates the toolbar with the current back navigation state.	14 // Updates the toolbar with the current back navigation state.

15 - (void)setCanGoBack:(BOOL)canGoBack;	15 - (void)setCanGoBack:(BOOL)canGoBack;

16 // Updates the toolbar with the current loading state.	16 // Updates the toolbar with the current loading state.

17 - (void)setIsLoading:(BOOL)isLoading;	17 - (void)setIsLoading:(BOOL)isLoading;

18 // Updates the toolbar with the current progress of the loading WebState.	18 // Updates the toolbar with the current progress of the loading WebState.

19 - (void)setLoadingProgress:(double)progress;	19 - (void)setLoadingProgress:(double)progress;

	20 // Updates the toolbar with the current number of total webstates.
	marq (ping after 24h) 2017/05/29 11:04:36 Nit: Total number of tabs. The consumer doesn't kn Nit: Total number of tabs. The consumer doesn't know anything about web states. sczs 2017/05/30 00:18:21 Done. Show quoted text On 2017/05/29 11:04:36, marq (ping after 24h) wrote: > Nit: Total number of tabs. The consumer doesn't know anything about web states. Done.
	21 - (void)setNumberOfTabs:(int)numberOfTabs;
	edchin 2017/05/27 16:25:06 nit: what's more common? numberOfThings or thingsC nit: what's more common? numberOfThings or thingsCount? No need to change anything. Just food for thought. sczs 2017/05/30 00:18:21 You're right, tabCount is much better! Changed it Show quoted text On 2017/05/27 16:25:06, edchin wrote: > nit: what's more common? numberOfThings or thingsCount? No need to change > anything. Just food for thought. You're right, tabCount is much better! Changed it :)
20 @end	22 @end

21	23

22 #endif // IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_CONSUMER_H_	24 #endif // IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_CONSUMER_H_

OLD	NEW