Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 2908593003: Fix bug in DocumentMarkerController::ShowMarkers() (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bug in DocumentMarkerController::ShowMarkers() I accidentally introduced a bug in DocumentMarkerController::ShowMarkers() in https://codereview.chromium.org/2820633002 causing it to crash if we have a node with a DocumentMarkerList for at least one MarkerType but not all MarkerTypes (this is very common). I hadn't noticed it until just now because this is a method only used to assist with debugging. This CL fixes the bug. BUG= Review-Url: https://codereview.chromium.org/2908593003 Cr-Commit-Position: refs/heads/master@{#474910} Committed: https://chromium.googlesource.com/chromium/src/+/0cab0229765caa47ee02c482d768ea65f6e24b5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
rlanday
3 years, 7 months ago (2017-05-25 21:59:17 UTC) #3
Xiaocheng
lgtm
3 years, 7 months ago (2017-05-25 22:07:34 UTC) #5
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-26 04:43:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908593003/1
3 years, 7 months ago (2017-05-26 04:43:56 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 04:50:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0cab0229765caa47ee02c482d768...

Powered by Google App Engine
This is Rietveld 408576698