Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2908583002: MD Settings: add overflow scroll to fix very constrained dialog heights. (Closed)

Created:
3 years, 7 months ago by scottchen
Modified:
3 years, 6 months ago
Reviewers:
dpapad
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: add overflow scroll to fix very constrained dialog heights. BUG=725460 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2908583002 Cr-Commit-Position: refs/heads/master@{#475210} Committed: https://chromium.googlesource.com/chromium/src/+/a28228813e02d31eb1fb50ec263594e5cad1b80a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
scottchen
3 years, 7 months ago (2017-05-25 18:19:19 UTC) #3
dpapad
L-G-T-M, but let's wait until the discussion on the bug has concluded.
3 years, 7 months ago (2017-05-25 21:43:42 UTC) #4
scottchen
On 2017/05/25 21:43:42, dpapad wrote: > L-G-T-M, but let's wait until the discussion on the ...
3 years, 7 months ago (2017-05-25 21:50:46 UTC) #5
dpapad
On 2017/05/25 at 21:50:46, scottchen wrote: > On 2017/05/25 21:43:42, dpapad wrote: > > L-G-T-M, ...
3 years, 7 months ago (2017-05-25 21:51:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908583002/1
3 years, 7 months ago (2017-05-25 23:10:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/303659)
3 years, 7 months ago (2017-05-26 03:46:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908583002/1
3 years, 6 months ago (2017-05-26 21:03:19 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-05-27 01:33:17 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a28228813e02d31eb1fb50ec2635...

Powered by Google App Engine
This is Rietveld 408576698