Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2908503003: Always relayout children of LayoutView when printing. (Closed)

Created:
3 years, 7 months ago by mstensho (USE GERRIT)
Modified:
3 years, 6 months ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Always relayout children of LayoutView when printing. We can normally trust UpdateLogicalWidth() to detect and report size changes, but this is not the case when printing, because FrameView::ForceLayoutForPagination() changes the logical width of the LayoutView behind our back. BUG=702778 Review-Url: https://codereview.chromium.org/2908503003 Cr-Commit-Position: refs/heads/master@{#475862} Committed: https://chromium.googlesource.com/chromium/src/+/7d39380b14728b8debd8bcc73672ff778018f63e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/printing/block-width-relayout-shrink.html View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/printing/block-width-relayout-shrink-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
3 years, 6 months ago (2017-05-29 07:00:26 UTC) #6
szager1
lgtm
3 years, 6 months ago (2017-05-31 00:44:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908503003/1
3 years, 6 months ago (2017-05-31 07:53:23 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 10:06:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7d39380b14728b8debd8bcc73672...

Powered by Google App Engine
This is Rietveld 408576698