Reland "arc: Invalidate app icon on package update."

Reland "arc: Invalidate app icon on package update."

BUG=725305
> Revert of arc: Invalide app icon on package update. (patchset #2 id:20001 of https://codereview.chromium.org/2896973002/ )

> Reason for revert:
> Will take a look mem issue

Original issue's description:
> arc: Invalide app icon on package update.
>
> ARC app icons need to be invalidated and app icon in app launcher and in
> shelf should be automatically updated.
>
> BUG=725305
> TEST=Manually + unit tests.
>
> Review-Url: https://codereview.chromium.org/2896973002
> Cr-Commit-Position: refs/heads/master@{#474443}
> Committed: https://chromium.googlesource.com/chromium/src/+/1f90c7dc31ae659ff560baebcabfe24c3e036312

Review-Url: https://codereview.chromium.org/2908483002
Cr-Commit-Position: refs/heads/master@{#474677}
Committed: https://chromium.googlesource.com/chromium/src/+/7355fde0d4368c35211724de3d11cbb77417aa49

[khmel, 2017-05-25 16:04:33]

Description was changed from

==========
Reland

> Revert of arc: Invalide app icon on package update. (patchset #2 id:20001 of
https://codereview.chromium.org/2896973002/ )

> Reason for revert:
> Will take a look mem issue

Original issue's description:
> arc: Invalide app icon on package update.
>
> ARC app icons need to be invalidated and app icon in app launcher and in
> shelf should be automatically updated.
>
> BUG=725305
> TEST=Manually + unit tests.
>
> Review-Url: https://codereview.chromium.org/2896973002
> Cr-Commit-Position: refs/heads/master@{#474443}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1f90c7dc31ae659ff560baebcabf...
==========

to

==========
Reland

BUG=725305

> Revert of arc: Invalide app icon on package update. (patchset #2 id:20001 of
https://codereview.chromium.org/2896973002/ )

> Reason for revert:
> Will take a look mem issue

Original issue's description:
> arc: Invalide app icon on package update.
>
> ARC app icons need to be invalidated and app icon in app launcher and in
> shelf should be automatically updated.
>
> BUG=725305
> TEST=Manually + unit tests.
>
> Review-Url: https://codereview.chromium.org/2896973002
> Cr-Commit-Position: refs/heads/master@{#474443}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1f90c7dc31ae659ff560baebcabf...
==========

[khmel, 2017-05-25 16:06:25]

khmel@chromium.org changed reviewers:
+ xiyuan@chromium.org

[khmel, 2017-05-25 16:06:26]

Hi Xiyuan,

Could you please confirm changes to fix previous CL. I commented changes I made.

PTAL
Thanks!

https://codereview.chromium.org/2908483002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_unittest.cc (right):

https://codereview.chromium.org/2908483002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_unittest.cc:197: void RestartArc() {
Moved restart code to helper to reuse.

https://codereview.chromium.org/2908483002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_unittest.cc:1341:
TEST_P(ArcAppModelBuilderRecreate, IconInvalidation) {
This is the actual fix. ArcAppModelBuilderRecreate has code to disable sync
service that cannot handle prefs restart.

[khmel, 2017-05-25 16:15:55]

https://codereview.chromium.org/2908483002/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_app_unittest.cc (right):

https://codereview.chromium.org/2908483002/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_unittest.cc:456: void RestartArc() {
Moved Restart here where this operation is safe to prevent problem in future
when someone will try to reuse Restart.

https://codereview.chromium.org/2908483002/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_unittest.cc:476: class ArcDefaulAppTest :
public ArcAppModelBuilderRecreate {
Now  ArcDefaulAppTest has base class ArcAppModelBuilderRecreate and
SetTestingFactory for sync service is used only one place

[xiyuan, 2017-05-25 16:16:04]

lgtm

Can you use a better subject line?

e.g.
Reland ->
Reland "arc: Invalide app icon on package update."

Note you need to also change the first line in the "Description" field so that
git commit message has correct subject too.

[khmel, 2017-05-25 16:26:19]

On 2017/05/25 16:16:04, xiyuan wrote:
> lgtm
> 
> Can you use a better subject line?
> 
> e.g.
> Reland ->
> Reland "arc: Invalide app icon on package update."
> 
> Note you need to also change the first line in the "Description" field so that
> git commit message has correct subject too.

Opps, missed this. Thanks!

[khmel, 2017-05-25 16:26:26]

Description was changed from

==========
Reland

BUG=725305

> Revert of arc: Invalide app icon on package update. (patchset #2 id:20001 of
https://codereview.chromium.org/2896973002/ )

> Reason for revert:
> Will take a look mem issue

Original issue's description:
> arc: Invalide app icon on package update.
>
> ARC app icons need to be invalidated and app icon in app launcher and in
> shelf should be automatically updated.
>
> BUG=725305
> TEST=Manually + unit tests.
>
> Review-Url: https://codereview.chromium.org/2896973002
> Cr-Commit-Position: refs/heads/master@{#474443}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1f90c7dc31ae659ff560baebcabf...
==========

to

==========
Reland "arc: Invalide app icon on package update."

BUG=725305

> Revert of arc: Invalide app icon on package update. (patchset #2 id:20001 of
https://codereview.chromium.org/2896973002/ )

> Reason for revert:
> Will take a look mem issue

Original issue's description:
> arc: Invalide app icon on package update.
>
> ARC app icons need to be invalidated and app icon in app launcher and in
> shelf should be automatically updated.
>
> BUG=725305
> TEST=Manually + unit tests.
>
> Review-Url: https://codereview.chromium.org/2896973002
> Cr-Commit-Position: refs/heads/master@{#474443}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1f90c7dc31ae659ff560baebcabf...
==========

[khmel, 2017-05-25 16:26:50]

Description was changed from

==========
Reland "arc: Invalide app icon on package update."

BUG=725305

> Revert of arc: Invalide app icon on package update. (patchset #2 id:20001 of
https://codereview.chromium.org/2896973002/ )

> Reason for revert:
> Will take a look mem issue

Original issue's description:
> arc: Invalide app icon on package update.
>
> ARC app icons need to be invalidated and app icon in app launcher and in
> shelf should be automatically updated.
>
> BUG=725305
> TEST=Manually + unit tests.
>
> Review-Url: https://codereview.chromium.org/2896973002
> Cr-Commit-Position: refs/heads/master@{#474443}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1f90c7dc31ae659ff560baebcabf...
==========

to

==========
Reland "arc: Invalidate app icon on package update."

BUG=725305

> Revert of arc: Invalide app icon on package update. (patchset #2 id:20001 of
https://codereview.chromium.org/2896973002/ )

> Reason for revert:
> Will take a look mem issue

Original issue's description:
> arc: Invalide app icon on package update.
>
> ARC app icons need to be invalidated and app icon in app launcher and in
> shelf should be automatically updated.
>
> BUG=725305
> TEST=Manually + unit tests.
>
> Review-Url: https://codereview.chromium.org/2896973002
> Cr-Commit-Position: refs/heads/master@{#474443}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1f90c7dc31ae659ff560baebcabf...
==========

[khmel, 2017-05-25 16:26:56]

The CQ bit was checked by khmel@chromium.org

[commit-bot: I haz the power, 2017-05-25 16:27:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 16:55:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495729616387140,
"parent_rev": "f828ef138004428ba6ea4767bd17efc8853d1f06", "commit_rev":
"7355fde0d4368c35211724de3d11cbb77417aa49"}

[commit-bot: I haz the power, 2017-05-25 16:55:43]

Description was changed from

==========
Reland "arc: Invalidate app icon on package update."

BUG=725305

> Revert of arc: Invalide app icon on package update. (patchset #2 id:20001 of
https://codereview.chromium.org/2896973002/ )

> Reason for revert:
> Will take a look mem issue

Original issue's description:
> arc: Invalide app icon on package update.
>
> ARC app icons need to be invalidated and app icon in app launcher and in
> shelf should be automatically updated.
>
> BUG=725305
> TEST=Manually + unit tests.
>
> Review-Url: https://codereview.chromium.org/2896973002
> Cr-Commit-Position: refs/heads/master@{#474443}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1f90c7dc31ae659ff560baebcabf...
==========

to

==========
Reland "arc: Invalidate app icon on package update."

BUG=725305

> Revert of arc: Invalide app icon on package update. (patchset #2 id:20001 of
https://codereview.chromium.org/2896973002/ )

> Reason for revert:
> Will take a look mem issue

Original issue's description:
> arc: Invalide app icon on package update.
>
> ARC app icons need to be invalidated and app icon in app launcher and in
> shelf should be automatically updated.
>
> BUG=725305
> TEST=Manually + unit tests.
>
> Review-Url: https://codereview.chromium.org/2896973002
> Cr-Commit-Position: refs/heads/master@{#474443}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1f90c7dc31ae659ff560baebcabf...

Review-Url: https://codereview.chromium.org/2908483002
Cr-Commit-Position: refs/heads/master@{#474677}
Committed:
https://chromium.googlesource.com/chromium/src/+/7355fde0d4368c35211724de3d11...
==========

[commit-bot: I haz the power, 2017-05-25 16:55:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7355fde0d4368c35211724de3d11...