DescriptionRevert of cc::SurfaceDependencyTracker should not crash when a Display goes away (patchset #16 id:300001 of https://codereview.chromium.org/2880023002/ )
Reason for revert:
I think this is probably responsible for new flake like this:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Tests%2F739%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FSamlTest.MetaRefreshToHTTPDisallowed%2F0
Original issue's description:
> cc::SurfaceDependencyTracker should not crash when a Display goes away
>
> Previously, SurfaceDependencyTracker was a BeginFrameObserver that
> directly observed BeginFrames from the first display. This is a problem
> if the first display goes away. This CL solves this problem by making
> SurfaceDependencyTracker observe an independent
> "PrimaryBeginFrameSource" instead. MojoFrameSinkManager owns
> SurfaceDependencyTracker and the PrimaryBeginFrameSource. When
> SurfaceDependencyTracker needs BeginFrames, that request goes to
> PrimaryBeginFrameSource which then adds itself as a BeginFrameObserver
> to the primary BeginFrameSource.
>
> When the primary BeginFrameSource goes away, PrimaryBeginFrameSource
> removes itself as an observer and, if necessary, adds itself as an
> observer arbitrarily to another BeginFrameSource. Future BeginFrames
> get forwarded from the PrimaryBeginFrameSource to
> SurfaceDependencyTracker.
>
> BUG=672962
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2880023002
> Cr-Commit-Position: refs/heads/master@{#474539}
> Committed: https://chromium.googlesource.com/chromium/src/+/b520968f4ac40fb89ce25329134b388ca42cca12
TBR=enne@chromium.org,vmpstr@chromium.org,fsamuel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672962
Review-Url: https://codereview.chromium.org/2908473002
Cr-Commit-Position: refs/heads/master@{#474653}
Committed: https://chromium.googlesource.com/chromium/src/+/a94c5212e856eec73332d8c761dfa905199bd064
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|