Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2908473002: Revert of cc::SurfaceDependencyTracker should not crash when a Display goes away (Closed)

Created:
3 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, cc-bugs_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc::SurfaceDependencyTracker should not crash when a Display goes away (patchset #16 id:300001 of https://codereview.chromium.org/2880023002/ ) Reason for revert: I think this is probably responsible for new flake like this: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Tests%2F739%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FSamlTest.MetaRefreshToHTTPDisallowed%2F0 Original issue's description: > cc::SurfaceDependencyTracker should not crash when a Display goes away > > Previously, SurfaceDependencyTracker was a BeginFrameObserver that > directly observed BeginFrames from the first display. This is a problem > if the first display goes away. This CL solves this problem by making > SurfaceDependencyTracker observe an independent > "PrimaryBeginFrameSource" instead. MojoFrameSinkManager owns > SurfaceDependencyTracker and the PrimaryBeginFrameSource. When > SurfaceDependencyTracker needs BeginFrames, that request goes to > PrimaryBeginFrameSource which then adds itself as a BeginFrameObserver > to the primary BeginFrameSource. > > When the primary BeginFrameSource goes away, PrimaryBeginFrameSource > removes itself as an observer and, if necessary, adds itself as an > observer arbitrarily to another BeginFrameSource. Future BeginFrames > get forwarded from the PrimaryBeginFrameSource to > SurfaceDependencyTracker. > > BUG=672962 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2880023002 > Cr-Commit-Position: refs/heads/master@{#474539} > Committed: https://chromium.googlesource.com/chromium/src/+/b520968f4ac40fb89ce25329134b388ca42cca12 TBR=enne@chromium.org,vmpstr@chromium.org,fsamuel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672962 Review-Url: https://codereview.chromium.org/2908473002 Cr-Commit-Position: refs/heads/master@{#474653} Committed: https://chromium.googlesource.com/chromium/src/+/a94c5212e856eec73332d8c761dfa905199bd064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -265 lines) Patch
M cc/scheduler/begin_frame_source_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M cc/surfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/surfaces/frame_sink_manager.h View 4 chunks +2 lines, -9 lines 0 comments Download
M cc/surfaces/frame_sink_manager.cc View 5 chunks +5 lines, -13 lines 0 comments Download
D cc/surfaces/primary_begin_frame_source.h View 1 chunk +0 lines, -56 lines 0 comments Download
D cc/surfaces/primary_begin_frame_source.cc View 1 chunk +0 lines, -87 lines 0 comments Download
M cc/surfaces/surface_dependency_tracker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/surfaces/surface_manager.h View 3 chunks +6 lines, -7 lines 0 comments Download
M cc/surfaces/surface_manager.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M cc/surfaces/surface_manager_unittest.cc View 2 chunks +0 lines, -61 lines 0 comments Download
M cc/surfaces/surface_synchronization_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M cc/test/begin_frame_source_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/viz/frame_sinks/mojo_frame_sink_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/viz/frame_sinks/mojo_frame_sink_manager.cc View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Ken Rockot(use gerrit already)
Created Revert of cc::SurfaceDependencyTracker should not crash when a Display goes away
3 years, 7 months ago (2017-05-25 15:01:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908473002/1
3 years, 7 months ago (2017-05-25 15:01:55 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 15:02:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a94c5212e856eec73332d8c761df...

Powered by Google App Engine
This is Rietveld 408576698